Skip test classes in NewOverSettersRule - #314
Merged
Merged
Conversation
…r not construction config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
NewOverSettersRulereports classes that are alwaysnew-ed with the same setters and suggests promoting those values to the constructor.Test classes trip a false positive: a test instantiates the subject with
newand then calls its methods to exercise behavior. Those calls are the test act, not construction-time configuration, so they should not drive a constructor-promotion suggestion.Example from a downstream project - a model is wired as a service in production (only conditionally invoked from an event subscriber), but two unit tests do
new GrapesJsBuilderModel(...)followed by->addOrEditEntity($email). SinceaddOrEditEntitystarts withadd, it was collected as a setter and the rule fired, even though the class is never configured this way in production.The collector now skips test classes via the existing
TestClassDetector.