Skip to content

Sweep open pull requests in the triage skill - #200

Merged
jserv merged 1 commit into
mainfrom
skills
Sep 30, 2026
Merged

jserv merged 1 commit into
mainfrom
skills

Conversation

@jserv

@jserv jserv commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Open pull requests stall on things the triage skill never looked at: workflow runs held for first-time contributors, outdated review threads, reviews left unanswered for over a week, branches that no longer merge, and two pull requests closing the same issue. This renames codetrial-issue-triage to codetrial-triage and adds a pull request sweep: pr-sweep.sh gathers all five in one read-only call, and pulls.md says what to do with each. A sweep applies the mechanical actions itself (approving a first-time contributor's held run, resolving an outdated thread, posting the fixed rebase request in rebase.md on a conflicting non-draft pull request and hiding the copies it supersedes), while a drafted nudge or overlap notice still waits for its exact text to be confirmed. A hand-written review that mentions rebase is never hidden automatically, since it may ask for more than the rebase.

Verified with shellcheck, shfmt and scripts/indent.sh --check; by running pr-sweep.sh against a stub gh serving fixtures for drafts, the viewer's own pull request, a stacked branch, a workflow-touching run, a stale run SHA, a trimmed fixed-text match and a fixed-text review carrying inline comments; and read-only against this repository, where it matched held runs to their pull requests by head SHA and found the #128/#143 overlap on #93 before #128 merged.


Summary by cubic

Adds a pull request sweep to the triage skill, which previously stalled on five things it never looked at: workflow runs held for first-time contributors, outdated review threads, reviews unanswered for over a week, branches that no longer merge, and two pull requests closing the same issue. Renames codetrial-issue-triage to codetrial-triage.

Sweep behavior

  • pr-sweep.sh gathers all five conditions in one read-only call; pulls.md says what to do with each.
  • A sweep applies mechanical actions itself: approves a first-time contributor's held run, resolves an outdated thread, and posts the fixed rebase request from rebase.md while hiding the copies it supersedes.
  • Held runs are matched by fork, branch and head SHA; nudges skip approved, hidden or truncated threads, and run approvals are withheld when workflows or files are truncated.
  • Drafted nudges and overlap notices still wait for their exact text to be confirmed.

Written for commit be33df4. Summary will update on new commits.

Review in cubic

Open pull requests stall on things triage never looked at: runs held
for first-time contributors, outdated review threads, reviews left
unanswered and branches that no longer merge. Rename the skill to
codetrial-triage and add a read-only sweep script that lists these,
plus pull requests closing the same issue. A sweep applies the
mechanical fixes itself: run approvals, thread resolutions, and the
fixed rebase request, hiding the copies it replaces only once it
lands. Drafted nudges still wait for the exact text to be confirmed.
@jserv
jserv merged commit 71398c4 into main Sep 30, 2026
6 checks passed
@jserv
jserv deleted the skills branch September 30, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant