Repository navigation
Defer numeric property formatting - #229
Open
vogelsgesang wants to merge 2 commits into
Open
vogelsgesang wants to merge 2 commits into
vogelsgesang wants to merge 2 commits into
Conversation
Keep numeric plan properties as numbers until they are rendered. This preserves their exact values for Plan Insights and other consumers while still presenting readable counts, byte sizes, and durations in node and metadata panels. Represent each scalar property as a PropertyEntry containing a string or number plus an optional NumberFormat hint. DuckDB and Hyper infer compatible formats from property names; Postgres limits inference to rounded counts because its timing and memory values use different units. Other loaders retain raw scalar values without inferred formatting. Move number presentation into a shared formatter and PropertyList used by both graph nodes and plan metadata. Keep complex JSON values flat and stringified so nested properties remain outside this change. Update loader consumers, documentation, focused formatter coverage, and loader output snapshots for the scalar entry representation.
vogelsgesang
force-pushed
the
defer-number-formatting
branch
from
October 29, 2026 02:19
46eaa24 to
2f540a6
Compare
Restore the formatter and property-model documentation carried by the original nested-properties work, and document that plan metadata uses the same scalar entry type as node properties. Keep loader parsing utilities distinct from the renderer-facing number-format module. Retain the original direct formatter cases, verify that Hyper and Postgres attach formats without changing raw numeric values, and cover formatting through the shared PropertyList renderer.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep numeric plan properties as numbers until they are rendered. This preserves their exact values for Plan Insights and other consumers while still presenting readable counts, byte sizes, and durations in node and metadata panels.
Represent each scalar property as a PropertyEntry containing a string or number plus an optional NumberFormat hint. DuckDB and Hyper infer compatible formats from property names; Postgres limits inference to rounded counts because its timing and memory values use different units. Other loaders retain raw scalar values without inferred formatting.
Move number presentation into a shared formatter and PropertyList used by both graph nodes and plan metadata. Keep complex JSON values flat and stringified so nested properties remain outside this change.
Update loader consumers, documentation, focused formatter coverage, and loader output snapshots for the scalar entry representation.