Delete default permissions does not take in a list #783

Activity

1. shinchris

   added

   bug

   on Jan 22, 2021
2. jacalata commented on Jun 7, 2022

   

   jacalata

   on Jun 7, 2022

   Contributor

   More actions

   Code comments currently in permissions_endpoint show that delete_permissions can take either a single rule or a list. We should update delete_default_permissions to do the same.
   # Delete is the only endpoint that doesn't take a list of rules
   # so let's fake it to keep it consistent
3. jacalata

   added

   enhancement

   and removed

   bug

   on Feb 16, 2023
4. jacalata commented on Feb 16, 2023

   

   jacalata

   on Feb 16, 2023

   Contributor

   More actions

   There's quite a few methods to update:
   
5. salvuswarez commented on Mar 15, 2023

   

   salvuswarez

   on Mar 15, 2023

   Last edited by salvuswarez

   More actions

   Hi there, first time responder, long time user of tsc here and i want to start with you guys are awesome and very much appreciate your work here. I was working through this recently and noticed that to fix it, all that seems to be needed is to apply the same signature and loop logic that is done on the delete permissions method in the permissions endpoint to the default_permissions_endpoint.

   first just update the signature, then add the check and outer loop.
   def delete_default_permission(self, resource: BaseItem, rules: Union[PermissionsRule,List[PermissionsRule]], content_type: Resource) -> None:

   # applying fix so that delete default endpoint can handle a list of rules like the delete permissions endpoint does
   if isinstance(rules,PermissionsRule):
       rules = [rules]
   for rule in rules:
       for capability, mode in rule.capabilities.items():...`
   
6. github-actions commented on Aug 6, 2026

   

   github-actionsBot

   on Aug 6, 2026 – with GitHub Actions

   More actions

   This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. If this is still relevant, please comment to keep it open.
7. github-actions

   added

   stale

   on Aug 6, 2026
8. github-actions commented on Aug 21, 2026

   

   github-actionsBot

   on Aug 21, 2026 – with GitHub Actions

   More actions

   Closing due to inactivity. If this is still relevant, please reopen or file a new issue.
9. github-actions

   closed this as not plannedon Aug 21, 2026
10. jacalata

    reopened this on Aug 21, 2026
11. jacalata

    added

    good first issue

    and removed

    stale

    on Aug 21, 2026