Repository navigation
encoding test is OS-specific #916
Description
Describe the bug
This test appears to be OS-dependant
FAIL: test_filter_sort_legacy (test.test_request_option.RequestOptionTests)
Traceback (most recent call last):
File "c:\dev\tsc\test\test_request_option.py", line 177, in test_filter_sort_legacy
self.assertTrue(re.search('filter=tags:in:%2bstocks,market%2d', resp.request.query))
AssertionError: None is not true
Versions
Fails on windows, if I adjust the expected value to match the encoding there it fails on linux.
Activity
un-fix test for now
t8y8 commentedon Oct 12, 2021
That might be related to the version of requests or urllib3 being run by the test, and not necessarily the OS... that's what I kind of remember from before
jacalata commentedon Jun 18, 2026
The failing assertion (
re.search('filter=tags:in:%2bstocks,market%2d', ...)) was checking for platform-specific URL encoding. The test has since been rewritten to useparse_qswhich handles encoding normalization correctly on all platforms. Passes on Windows and Linux. Closing.