Repository navigation
CI: fail on undefined variables, lint workflows, update actions - #376
Open
jackspiering wants to merge 2 commits into
Open
jackspiering wants to merge 2 commits into
jackspiering wants to merge 2 commits into
Conversation
The other two workflows cancel a superseded pull request run. The workflow lint now does the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tightens the Compose validation and lint workflows.
.envdoes not list is flagged.paths:filters are removed, so the check runs on every pull request and can be made required.Compose files, and the log shows the Compose version..envare now empty values (this is what produced the warnings). The rendered Compose output is identical before and after.paths-ignoreblocks, so a PR that touches onlyLICENSEor.gitignorecannot stay "Pending". Adds a step that fails when the rumdl action version and itsversion:input disagree.persist-credentials: falseon every checkout.workflow-lint.yml(actionlint and zizmor, only on.github/**changes, with the sameconcurrencyblock as the other workflows), anddependabot.ymlfor the pinned actions.Related Issues
Verification
bash -eo pipefailagainst Compose v5.6.0 and v2.38.2 (the runner's version): exit 0 on this branch. Before the Formbricks fix it flags only Formbricks, with the 41 names. A broken Serve JSON and a renamed required variable are both flagged. EspoCRM needs at most 4 dummy variables.actions/checkoutv7.0.1,zizmor-actionv0.6.4, and the actionlint sha256.Checklist
Additional Context
From an external review of the repository (section 4).
Compose filesto the required status checks ofmain.lintkeeps its name, because branch protection requires it.Workflow lintshould not be required.