Skip to content

fix(loops): the verdict-capable analyst channel + the worker completion cap#259

Merged
drewstone merged 1 commit into
mainfrom
fix/measurement-channels
Jun 11, 2026
Merged

fix(loops): the verdict-capable analyst channel + the worker completion cap#259
drewstone merged 1 commit into
mainfrom
fix/measurement-channels

Conversation

@drewstone

Copy link
Copy Markdown
Contributor

The two broken measurement channels from tonight's autopsies, fixed in one work-line:

consult() — the raw firewalled analyst channel (the E8 fix)

The belief-arm autopsy proved critique() cannot carry verdict formats — observe()'s findings extraction strips them. StrategyCtx.consult(messages, instruction) is the verdict-capable channel: the critic answers the body's instruction over the compacted trajectory verbatim. Same firewall (trajectory in, never scores), same billing as the critique path. The belief arm rewrites onto it with a calibration floor (STOP obeyed only at confidence ≥0.7); the corner becomes measurable.

AgenticOptions.maxTokens — the worker completion cap (the kimi fix)

runShot sent no max_tokens, so thinking workers return empty content everywhere — the matrix's kimi row measured a broken channel, not the model. WORKER_MAX_TOKENS wired through all three runners.

Plus: ARMS= filter on steering-modes for targeted re-runs; the test router stub now serves both response-reading styles (its missing text() was silently downing consult/critique leaves under test).

+1 test (instruction reaches the analyst verbatim; raw reply intact). Suite 790 ✓ · typecheck ✓ · lint ✓. Launching on merge: kimi+glm matrix re-runs, the belief re-run, the deeper-search cost run.

…on cap

The two measurement channels the autopsies demanded:

- StrategyCtx.consult(messages, instruction): the RAW firewalled analyst
  channel — the critic answers the body's instruction over the compacted
  trajectory verbatim (no findings extraction), so verdict-shaped steering
  (CONTINUE/STOP decisions, calibrated predictions) survives the wire. Same
  firewall as critique (trajectory in, never scores), same billing. The
  belief arm rewrites onto it with a confidence floor (an uncertain STOP is
  not obeyed); the E8 corner becomes measurable.
- AgenticOptions.maxTokens → runShot: thinking workers (kimi-class) burn
  unbounded budgets on reasoning and return empty content without a
  completion cap — the matrix's kimi row measured a broken channel, not the
  model. WORKER_MAX_TOKENS wired through grid/evolve/steering runners.
- steering-modes gains ARMS=refine,belief (targeted re-runs); the test
  router stub now serves both response-reading styles (json + text — a stub
  missing text() silently downed every consult/critique leaf in tests).

@tangletools tangletools left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved PR — 61461cfd

Blanket team auto-approval is enabled for this reviewer service.
The full PR reviewer audit still runs separately and will publish findings if it detects issues.

tangletools · auto-approval · reason: blanket_auto_approve · 2026-06-11T12:30:22Z

@drewstone drewstone merged commit e562ba6 into main Jun 11, 2026
1 check passed
@drewstone drewstone deleted the fix/measurement-channels branch June 11, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants