fix(loops): normalize advisory deliverable fields — an authored omission cannot poison the next generation#261
Merged
Conversation
…ion cannot poison the next generation The deeper cost run crashed at gen2 authoring: an authored body returned a StrategyResult without progression (advisory, unvalidated since #217 made score/resolved harness-owned), the undefined rode through runBenchmark into the losses table, and compactLosses threw on .map — killing the run a generation AFTER the offending candidate ran. defineStrategy now normalizes progression/completions/shots on the deliverable (the source fix); compactLosses tolerates absence anyway (depth). Test: a body returning only {score, resolved} yields a well-formed cell.
tangletools
approved these changes
Jun 11, 2026
tangletools
left a comment
tangletools
left a comment
Contributor
There was a problem hiding this comment.
✅ Auto-approved PR — c4bb3bb8
Blanket team auto-approval is enabled for this reviewer service.
The full PR reviewer audit still runs separately and will publish findings if it detects issues.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-06-11T14:34:42Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deeper cost run (GENS=3 POP=4) crashed at gen2 authoring with a delayed fuse: an authored body returned a
StrategyResultwithoutprogression— advisory and unvalidated since #217 made score/resolved harness-owned — and the undefined rode throughrunBenchmark's cells into the losses table, wherecompactLossesthrew on.mapone full generation after the offending candidate ran.defineStrategynormalizesprogression/completions/shotson the deliverable — no downstream consumer (losses, anytime curves, waterfalls) can ever see undefined advisory fields.compactLossestolerates absence regardless.{score, resolved}yields a well-formed cell with the harness-verified score.The run resumes from its gen0+gen1 ledger (third-generation-only re-pay) once the in-flight corpus A/B releases the gym. Suite 791 ✓.