build: bump dsptap for the cmake floor fix - #35
Merged
Conversation
28a34a1..41215c6
This repo declares a 3.19 floor, but the pinned dsptap declared 3.24, and a
nested submodule refuses first -- so the effective floor was 3.24 regardless.
That excluded Ubuntu 22.04 LTS, which ships cmake 3.22.1: a stock 22.04 machine
could not configure this project, or anything consuming it.
dsptap's floor is now 3.22 upstream, so this moves the pin onto it. The pinned
tree reads 3.19 here and 3.22 in dsptap, which configures on 22.04.
The range also carries three unrelated commits that were already on dsptap main:
ff6fc6c fft: place the vDSP split buffers on the accurate kernel, with a
tonal test
da4dd68 fft: align the vDSP split buffers -- root cause and fix for a
float32 flake
804cb17 Build the C ABI from the root and in CI; drop committed __pycache__
Testing and Verification Instructions:
1. git submodule update --init --recursive
2. rm -rf build && cmake -S . -B build -DCMAKE_BUILD_TYPE=Release
3. cmake --build build && ctest --test-dir build
Before and after are identical: 1758389 assertions in 322 test cases, all
passing. The assertion counts matching exactly is the point -- the two FFT
commits in this range touch the vDSP path, and nothing in the suite moved.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the
dsptapsubmodule pin,28a34a1..41215c6.Why
This repo declares a 3.19 cmake floor, but the pinned dsptap declared 3.24 — and
a nested submodule refuses first, so the effective floor was 3.24 regardless.
That excluded Ubuntu 22.04 LTS, which ships cmake 3.22.1: a stock 22.04
machine could not configure this project, or anything consuming it. dsptap's
floor is now 3.22 upstream, so moving the pin brings the effective floor to 3.22.
What else is in the range
Three commits already on dsptap
main, carried along by the bump:ff6fc6cfft: place the vDSP split buffers on the accurate kernel, with a tonal testda4dd68fft: align the vDSP split buffers — root cause and fix for a float32 flake804cb17Build the C ABI from the root and in CI; drop committed__pycache__Verification
Full suite before and after, built from scratch in Release:
Identical on both sides. The exact match is the point — two of the commits in
this range touch the vDSP FFT path, and nothing in the suite moved.
🤖 Generated with Claude Code