Repository navigation
Conversation
taras
added a commit
that referenced
this pull request
Nov 17, 2026
taras
marked this pull request as ready for review
November 17, 2026 13:20
Base automatically changed from
codex/1171-guarded-journal-migrations
to
main
November 17, 2026 13:52
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The read-only Core subprocess completes before its parent's assertions about the denied write. Those assertions can now retain the journal of the subprocess that actually ran. Advances #1171 and builds on #1358.
What changes
Review guide
Start with the late-assertion and passing controls in
packages/core/tests/component-module-loader.test.ts. The Workflow identity comparison retains the ordinary run and both original bundles on independent streams.How to verify it
f192591b0.Scope
The migration ledger leaves 95 pending and 44 partial owner rows for the rest of #1171.
Scope confirmation