Conversation
Setting `onclick` on the tooltip context now renders a focusable target per data point. Tab steps through them in data order, focusing one shows its tooltip, and Enter or Space calls the same handler a pointer click would. Radial charts and manual mode wire their own events, so they are excluded. Refs techniq#222
🦋 Changeset detectedLatest commit: 3b4a4b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Contributor
Bundle Size Analysis
|
| Item | Current | New | Change |
|---|---|---|---|
🔴 Tooltip |
149.66 KB 36.18 gz |
151.19 KB 36.61 gz |
+1.53 KB (+1.0%) +0.42 gz (+1.2%) |
Use-Case Scenarios
Core (7 changed)
| Scenario | Current | New | Change |
|---|---|---|---|
🟡 core-canvas |
232.06 KB 59.70 gz |
233.63 KB 60.16 gz |
+1.57 KB (+0.7%) +0.46 gz (+0.8%) |
🟡 core-line |
230.29 KB 58.42 gz |
231.84 KB 58.86 gz |
+1.56 KB (+0.7%) +0.43 gz (+0.7%) |
🟡 core-scatter |
221.21 KB 55.90 gz |
222.77 KB 56.32 gz |
+1.56 KB (+0.7%) +0.43 gz (+0.8%) |
🟡 core-geo |
216.97 KB 55.52 gz |
218.52 KB 55.94 gz |
+1.56 KB (+0.7%) +0.42 gz (+0.8%) |
🟡 core-html |
216.37 KB 54.97 gz |
217.93 KB 55.41 gz |
+1.56 KB (+0.7%) +0.44 gz (+0.8%) |
🟡 core |
214.29 KB 54.40 gz |
215.85 KB 54.82 gz |
+1.56 KB (+0.7%) +0.42 gz (+0.8%) |
🟡 core-svg |
214.29 KB 54.48 gz |
215.85 KB 54.91 gz |
+1.56 KB (+0.7%) +0.43 gz (+0.8%) |
Base (agnostic) (4 changed)
| Scenario | Current | New | Change |
|---|---|---|---|
🟡 base-svg-agnostic |
358.92 KB 83.24 gz |
360.53 KB 83.67 gz |
+1.62 KB (+0.5%) +0.43 gz (+0.5%) |
🟡 base-canvas-agnostic |
358.92 KB 83.25 gz |
360.53 KB 83.66 gz |
+1.62 KB (+0.5%) +0.42 gz (+0.5%) |
🟡 base-html-agnostic |
358.92 KB 83.25 gz |
360.53 KB 83.67 gz |
+1.62 KB (+0.5%) +0.42 gz (+0.5%) |
🟡 base |
358.91 KB 83.24 gz |
360.53 KB 83.67 gz |
+1.62 KB (+0.5%) +0.43 gz (+0.5%) |
Base (layer-specific) (3 changed)
| Scenario | Current | New | Change |
|---|---|---|---|
🟡 base-canvas |
346.80 KB 80.99 gz |
348.42 KB 81.41 gz |
+1.62 KB (+0.5%) +0.42 gz (+0.5%) |
🟡 base-html |
339.19 KB 78.71 gz |
340.81 KB 79.13 gz |
+1.62 KB (+0.5%) +0.42 gz (+0.5%) |
🟡 base-svg |
337.11 KB 78.22 gz |
338.72 KB 78.65 gz |
+1.61 KB (+0.5%) +0.42 gz (+0.5%) |
Cartesian charts (27 changed)
| Scenario | Current | New | Change |
|---|---|---|---|
🟡 PieChart |
399.77 KB 92.05 gz |
401.39 KB 92.46 gz |
+1.62 KB (+0.4%) +0.41 gz (+0.4%) |
🟡 ArcChart |
393.01 KB 90.70 gz |
394.63 KB 91.12 gz |
+1.62 KB (+0.4%) +0.41 gz (+0.5%) |
🟡 LineChart |
389.31 KB 90.39 gz |
390.92 KB 90.81 gz |
+1.62 KB (+0.4%) +0.42 gz (+0.5%) |
🟡 PieChart-canvas |
385.64 KB 89.45 gz |
387.26 KB 89.90 gz |
+1.63 KB (+0.4%) +0.46 gz (+0.5%) |
🟡 AreaChart |
381.34 KB 88.01 gz |
382.96 KB 88.44 gz |
+1.62 KB (+0.4%) +0.44 gz (+0.5%) |
🟡 ArcChart-canvas |
379.46 KB 88.19 gz |
381.07 KB 88.63 gz |
+1.61 KB (+0.4%) +0.43 gz (+0.5%) |
🟡 area-chart |
376.99 KB 87.04 gz |
378.61 KB 87.51 gz |
+1.62 KB (+0.4%) +0.47 gz (+0.5%) |
🟡 PieChart-svg |
375.97 KB 86.66 gz |
377.59 KB 87.12 gz |
+1.63 KB (+0.4%) +0.46 gz (+0.5%) |
🟡 line-chart-interactive |
375.57 KB 87.02 gz |
377.18 KB 87.42 gz |
+1.62 KB (+0.4%) +0.40 gz (+0.5%) |
🟡 pie-chart |
371.22 KB 85.79 gz |
372.84 KB 86.21 gz |
+1.61 KB (+0.4%) +0.42 gz (+0.5%) |
🟡 ArcChart-svg |
369.79 KB 85.46 gz |
371.39 KB 85.87 gz |
+1.60 KB (+0.4%) +0.42 gz (+0.5%) |
🟡 BarChart |
369.36 KB 85.31 gz |
370.98 KB 85.72 gz |
+1.62 KB (+0.4%) +0.41 gz (+0.5%) |
🟡 AreaChart-canvas |
368.42 KB 85.64 gz |
370.04 KB 86.07 gz |
+1.62 KB (+0.4%) +0.43 gz (+0.5%) |
🟡 bar-chart |
363.54 KB 84.09 gz |
365.16 KB 84.51 gz |
+1.62 KB (+0.4%) +0.42 gz (+0.5%) |
🟡 ScatterChart |
363.52 KB 84.25 gz |
365.14 KB 84.64 gz |
+1.62 KB (+0.4%) +0.39 gz (+0.5%) |
🟡 scatter-chart |
360.00 KB 83.53 gz |
361.62 KB 83.94 gz |
+1.62 KB (+0.4%) +0.41 gz (+0.5%) |
🟡 line-chart |
359.41 KB 83.29 gz |
361.03 KB 83.72 gz |
+1.62 KB (+0.4%) +0.43 gz (+0.5%) |
🟡 AreaChart-svg |
358.75 KB 82.90 gz |
360.37 KB 83.33 gz |
+1.62 KB (+0.5%) +0.43 gz (+0.5%) |
🟡 BarChart-canvas |
356.13 KB 82.95 gz |
357.75 KB 83.36 gz |
+1.62 KB (+0.5%) +0.41 gz (+0.5%) |
🟡 LineChart-canvas |
353.37 KB 82.50 gz |
354.99 KB 82.96 gz |
+1.62 KB (+0.5%) +0.46 gz (+0.6%) |
🟡 ScatterChart-canvas |
350.52 KB 81.77 gz |
352.14 KB 82.22 gz |
+1.62 KB (+0.5%) +0.45 gz (+0.6%) |
🟡 line-chart-canvas |
346.82 KB 81.01 gz |
348.44 KB 81.43 gz |
+1.62 KB (+0.5%) +0.42 gz (+0.5%) |
🟡 BarChart-svg |
346.46 KB 80.18 gz |
348.08 KB 80.57 gz |
+1.63 KB (+0.5%) +0.39 gz (+0.5%) |
🟡 LineChart-svg |
343.69 KB 79.76 gz |
345.31 KB 80.18 gz |
+1.62 KB (+0.5%) +0.42 gz (+0.5%) |
🟡 ScatterChart-svg |
340.85 KB 79.03 gz |
342.46 KB 79.46 gz |
+1.62 KB (+0.5%) +0.43 gz (+0.5%) |
🟡 line-chart-html |
339.22 KB 78.73 gz |
340.83 KB 79.15 gz |
+1.62 KB (+0.5%) +0.42 gz (+0.5%) |
🟡 line-chart-svg |
337.13 KB 78.23 gz |
338.75 KB 78.66 gz |
+1.61 KB (+0.5%) +0.43 gz (+0.6%) |
Geo (3 changed)
| Scenario | Current | New | Change |
|---|---|---|---|
🟡 geo-full |
433.49 KB 102.62 gz |
435.14 KB 103.03 gz |
+1.65 KB (+0.4%) +0.41 gz (+0.4%) |
🟡 geo-tiles |
381.02 KB 88.85 gz |
382.63 KB 89.23 gz |
+1.62 KB (+0.4%) +0.38 gz (+0.4%) |
🟡 geo |
375.90 KB 87.15 gz |
377.52 KB 87.60 gz |
+1.62 KB (+0.4%) +0.45 gz (+0.5%) |
Hierarchy (4 changed)
| Scenario | Current | New | Change |
|---|---|---|---|
🟡 hierarchy-tree |
369.69 KB 86.18 gz |
371.31 KB 86.61 gz |
+1.62 KB (+0.4%) +0.42 gz (+0.5%) |
🟡 hierarchy-treemap |
366.31 KB 85.32 gz |
367.93 KB 85.74 gz |
+1.62 KB (+0.4%) +0.42 gz (+0.5%) |
🟡 hierarchy-pack |
365.98 KB 85.34 gz |
367.60 KB 85.76 gz |
+1.62 KB (+0.4%) +0.42 gz (+0.5%) |
🟡 dodge |
363.70 KB 84.65 gz |
365.32 KB 85.10 gz |
+1.62 KB (+0.4%) +0.45 gz (+0.5%) |
Graph / network (4 changed)
| Scenario | Current | New | Change |
|---|---|---|---|
🟡 dagre |
428.44 KB 102.19 gz |
430.07 KB 102.59 gz |
+1.63 KB (+0.4%) +0.40 gz (+0.4%) |
🟡 force |
372.10 KB 86.99 gz |
373.72 KB 87.41 gz |
+1.62 KB (+0.4%) +0.42 gz (+0.5%) |
🟡 sankey |
371.91 KB 86.40 gz |
373.53 KB 86.82 gz |
+1.62 KB (+0.4%) +0.42 gz (+0.5%) |
🟡 chord |
368.60 KB 85.51 gz |
370.21 KB 85.90 gz |
+1.61 KB (+0.4%) +0.39 gz (+0.5%) |
Components (1 changed)
| Scenario | Current | New | Change |
|---|---|---|---|
🔴 Tooltip |
149.66 KB 36.18 gz |
151.19 KB 36.61 gz |
+1.53 KB (+1.0%) +0.42 gz (+1.2%) |
Worst case (1 changed)
| Scenario | Current | New | Change |
|---|---|---|---|
🟡 all |
1042.75 KB 243.68 gz |
1044.37 KB 244.09 gz |
+1.62 KB (+0.2%) +0.41 gz (+0.2%) |
Understanding this report
- Use-case scenarios measure the bundle cost of common chart configurations (e.g. a line chart with axes)
- Individual components measure each component imported in isolation
- Svelte runtime is excluded; sizes reflect layerchart + its dependencies (d3, etc.)
- When multiple components share dependencies (e.g. d3-scale), the real-world cost is lower than the sum of individual sizes
- Changes smaller than 10 bytes or 0.1% are considered insignificant
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Setting
onclickontooltipContextnow also gives the chart keyboard access. Each data point gets an invisible focusable target: Tab steps through them in data order, focusing one shows its tooltip, and Enter or Space calls the sameonclickhandler with that data point. The targets are positioned with the chart's own scales, so they work with the built-in modes (bisect, band, bounds, quadtree, voronoi) and with facets, and the layer only renders whenonclickis set. Radial charts andmanualmode wire their own events on their own shapes, so they are left out.This covers the second item of #222. Edge hover hit areas and a persistent (popover-style) tooltip are still open there.
Test plan
pnpm test:unit --project client(792 passed, including 5 new tests inTooltipContext.svelte.test.ts)pnpm test:unit --project server --project ssr(208 passed)pnpm check:packagespnpm lint:packages(the two files it flags are unformatted onmainalready, untouched here)Refs #222