Repository navigation
fix: keep raw text elements out of Markdown parsing - #40
Merged
Merged
Conversation
Benchmark ResultsComparison of Open to see the benchmark resultsNo benchmark changes above ±5%. Generated by phpbench against commit 2ce1e2d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes part of #37 (point 3).
HtmlToken::parse()re-parses its own content with the inline rules, so the body of a<script>or<style>element was treated as Markdown:CommonMark calls these raw text elements —
pre,script,style,textarea, §4.6 type 1 — and never parses their content.HtmlRulenow marks those tokensraw(case-insensitively) andHtmlToken::parse()returns their content untouched. Every other element keeps parsing Markdown inside it, which is Tempest's own behaviour and unrelated to #20:This is the parsing half of point 3. Escaping literal text (
a\*b,a_b_c, quotes and entities in text tokens) is the other half and is not in this PR.composer test(333 tests),lintandanalyseare clean.