Conversation
Member
|
I'm confused, these aren't Tempest's official logo? https://github.com/tempestphp/.github/tree/main/logo_current |
Author
|
You're absolutely right @brendt It was created as a demonstration/community asset and as a small fan tribute. We like it enough that we're about to have T-Shirts printed with it as our little Tempest fanboy outfit. 😄 I've updated the PR description. |
Member
Ok so I've got to ask how much AI is involved in this conversation 😅 To be clear: I think part of this PR makes sense, but I don't understand why another logo should be shipped with the default app? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for an optional
APP_LOGOenvironment variable and use the official Tempest logo as the example configuration.When configured, the logo is rendered above the Tempest heading on the home page.
The official logo is provided as an example in
.env.example:The included
tempest-logo.pngis sourced from the official Tempest branding repository.If
APP_LOGOis not set in the application's environment, no logo is rendered.The custom logo assets in
public/img/custom/are community-created demonstrations and a small fan tribute from the German-speaking PHP user group community, including the PHP elephant as a nod to the wider PHP ecosystem. They are kept separately from the official branding and may also serve as examples for future custom/community branding.What changed?
APP_LOGOsupport to the homepage viewAPP_LOGOwith the official logo as an example to.env.examplepublic/img/public/img/custom/