-
-
Notifications
You must be signed in to change notification settings - Fork 185
fix(database): resolve uuid primary keys from positional insert bindings #2301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
radoslav-grencik
wants to merge
4
commits into
tempestphp:3.x
Choose a base branch
from
radoslav-grencik:fix/uuid-pk-relation-inserts
base: 3.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+481
−2
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
25e629f
fix(database): resolve uuid primary keys from positional insert bindings
radoslav-grencik d470bb5
fix(database): generate uuids in iterable inserts and add uuid foreig…
radoslav-grencik 4d7d1ed
docs(database): document uuid foreign key columns
radoslav-grencik dbe65d6
fix(database): treat explicit 0 id as fallback in positional PK resol…
radoslav-grencik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Tempest\Database\QueryStatements; | ||
|
|
||
| use Tempest\Database\Config\DatabaseDialect; | ||
| use Tempest\Database\QueryStatement; | ||
|
|
||
| /** | ||
| * A UUID column that is not a primary key. Uses `CHAR(36)` for MySQL, `UUID` for PostgreSQL, and `TEXT` for SQLite. | ||
| */ | ||
| final readonly class UuidStatement implements QueryStatement | ||
| { | ||
| public function __construct( | ||
| private string $name, | ||
| private bool $nullable = false, | ||
| ) {} | ||
|
|
||
| public function compile(DatabaseDialect $dialect): string | ||
| { | ||
| $name = $dialect->quoteIdentifier($this->name); | ||
| $nullable = $this->nullable ? '' : ' NOT NULL'; | ||
|
|
||
| return match ($dialect) { | ||
| DatabaseDialect::MYSQL => "{$name} CHAR(36){$nullable}", | ||
| DatabaseDialect::POSTGRESQL => "{$name} UUID{$nullable}", | ||
| DatabaseDialect::SQLITE => "{$name} TEXT{$nullable}", | ||
| }; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
packages/database/tests/QueryStatements/UuidStatementTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Tempest\Database\Tests\QueryStatements; | ||
|
|
||
| use PHPUnit\Framework\Attributes\Test; | ||
| use PHPUnit\Framework\TestCase; | ||
| use Tempest\Database\Config\DatabaseDialect; | ||
| use Tempest\Database\QueryStatements\UuidStatement; | ||
|
|
||
| /** | ||
| * @internal | ||
| */ | ||
| final class UuidStatementTest extends TestCase | ||
| { | ||
| #[Test] | ||
| public function mysql_compilation(): void | ||
| { | ||
| $statement = new UuidStatement('author_id'); | ||
| $compiled = $statement->compile(DatabaseDialect::MYSQL); | ||
|
|
||
| $this->assertSame('`author_id` CHAR(36) NOT NULL', $compiled); | ||
| } | ||
|
|
||
| #[Test] | ||
| public function postgresql_compilation(): void | ||
| { | ||
| $statement = new UuidStatement('author_id'); | ||
| $compiled = $statement->compile(DatabaseDialect::POSTGRESQL); | ||
|
|
||
| $this->assertSame('"author_id" UUID NOT NULL', $compiled); | ||
| } | ||
|
|
||
| #[Test] | ||
| public function sqlite_compilation(): void | ||
| { | ||
| $statement = new UuidStatement('author_id'); | ||
| $compiled = $statement->compile(DatabaseDialect::SQLITE); | ||
|
|
||
| $this->assertSame('`author_id` TEXT NOT NULL', $compiled); | ||
| } | ||
|
|
||
| #[Test] | ||
| public function nullable_compilation(): void | ||
| { | ||
| $statement = new UuidStatement('author_id', nullable: true); | ||
|
|
||
| $this->assertSame('`author_id` CHAR(36)', $statement->compile(DatabaseDialect::MYSQL)); | ||
| $this->assertSame('"author_id" UUID', $statement->compile(DatabaseDialect::POSTGRESQL)); | ||
| $this->assertSame('`author_id` TEXT', $statement->compile(DatabaseDialect::SQLITE)); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function name is inconsistent with our other names. We should probably repurpose
uuidfor this instead, and useprimaryas the sole way of creating primary UUIDs.Would be breaking though, so for next major.