chore: use StructArmed on QA - #2302
Closed
samsonasik wants to merge 1 commit into
Closed
samsonasik wants to merge 1 commit into
samsonasik wants to merge 1 commit into
Conversation
samsonasik
requested review from
aidan-casey,
brendt and
innocenzi
as code owners
September 18, 2026 09:49
samsonasik
force-pushed
the
use-structarmed-on-qa
branch
from
September 18, 2026 09:51
a8f25c9 to
3bd8709
Compare
Benchmark ResultsComparison of Open to see the benchmark results
Generated by phpbench against commit 3bd8709 |
Contributor
Author
|
Ready for review/merge 👍 |
Member
|
Hey @samsonasik, thanks for the PR! I am going to close this for the time being, as it doesn't fit with our current architecture testing toolset (PHPStan + PHPat). Going forward, I would recommend making an issue for large refactors like this one to ensure it fits with the vision of the project. Thanks again for your work here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this PR add StructArmed to QA
https://github.com/boundwize/structarmed
It is a configurable PHP architecture guards with built in presets (psr4, mvc, and so on).
It already used by PHP frameworks:
This PR apply
StructArmedwith register:MustBeStaticAnonymousFunctionRuleto make use ofstaticin anonymous function when possible, applied wtih:Current skip
testspaths and andpackages/auth/src/Installerfor easier to review and gradual updates next.