Skip to content

Regenerate tcld command reference docs (fix grammar template) - #5119

Merged
Duncanma merged 2 commits into
mainfrom
fix-tcld-command-reference-grammar
Aug 14, 2026
Merged

Regenerate tcld command reference docs (fix grammar template)#5119
Duncanma merged 2 commits into
mainfrom
fix-tcld-command-reference-grammar

Conversation

@Duncanma

@Duncanma Duncanma commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #5113 — the tcld reference pages under docs/cloud/tcld/ had grammar errors like:

The tcld namespace capacity command manage namespace capacity.

These pages are auto-generated, so the real fix is in the gen-docs tool template in the temporalio/tcld repo, not here. That fix is in tcld#499 (unmerged — the repo isn't getting many updates). This PR copies that PR's corrected output into this repo.

Changes in tcld#499's cmd/gen-docs/main.go:

  • Replaced "The `%s` command %s." (with lowercaseFirst) with "`%s`: %s.", so the sentence reads correctly whether the source Usage string is a noun phrase or an imperative verb.
  • Restored the plain-English for example/that is wording in three Usage strings (app/apikey.go, app/namespace.go) that a straight regeneration would have silently reverted, since those two generated pages had been hand-patched for the Latin-abbreviation cleanup in Replace Latin abbreviations in hand-written docs #5100.

Why draft

This is blocked on tcld#499 (or the competing tcld#398) actually merging — per AGENTS.md, opening as draft until that lands. Marking ready for review once it does.

Test plan

  • vale --config .vale-ci.ini docs/cloud/tcld/ — 0 errors/warnings/suggestions
  • yarn build — succeeds, no MDX/broken-link errors
  • Diffed regenerated output against current docs/cloud/tcld/*.mdx: every change is either the template fix or legitimate drift from newer tcld commands since the docs were last generated; no unexpected regressions

┆Attachments: EDU-6963 Regenerate tcld command reference docs (fix grammar template)

Fixes the "The `tcld namespace capacity` command manage namespace
capacity." grammar error and similar cases across the tcld reference,
plus restores the plain-English e.g./i.e. wording from a prior hand
patch that a straight regeneration would have reverted.

The actual fix is in the gen-docs tool template in the tcld repo
(unmerged PR temporalio/tcld#499); this just
copies its corrected output into the docs repo.

Fixes #5113
Copilot AI balanced review requested due to automatic review settings August 14, 2026 21:54
@vercel

vercel Bot commented Aug 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
temporal-documentation Ready Ready Preview Aug 14, 2026 10:08pm

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown
Contributor

@Duncanma
Duncanma marked this pull request as ready for review August 14, 2026 22:07
@Duncanma
Duncanma requested a review from a team as a code owner August 14, 2026 22:07
@Duncanma
Duncanma merged commit 28eba6d into main Aug 14, 2026
14 checks passed
@Duncanma
Duncanma deleted the fix-tcld-command-reference-grammar branch August 14, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tcld reference docs: gen-docs template produces subject-verb agreement errors (e.g. "command manage namespace capacity")

3 participants