Add test verifying worker command polls omit versioning metadata - #3004
Merged
Conversation
rkannan82
changed the title
Add a dedicated test that starts a worker with deployment options and verifies via gRPC interceptor that normal nexus polls carry deploymentOptions while worker-command polls do not. This strengthens the coverage from #2987 where the existing test used an unversioned worker, making the assertions pass trivially. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rkannan82
force-pushed
the
kannan/fix-versioning-test
branch
from
August 12, 2026 22:31
f93b3bc to
7ff9ebd
Compare
rkannan82
changed the title
- Register EchoNexusServiceImpl so the normal nexus poller starts (without it, NexusTaskHandlerImpl.start() returns false and no normal nexus polls are issued, making the positive assertion fail) - Bump test timeout from 15s to 30s for headroom Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Configure deployment options (without useVersioning) on the existing ActivityCancellationTokenIntegrationTest worker, register a nexus service so the normal poller starts, and assert both sides: normal polls carry deploymentOptions, worker-command polls do not. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sushisource
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Harden the versioning assertions in
ActivityCancellationTokenIntegrationTestby configuring the worker with deployment options and asserting both sides: normal nexus polls carrydeploymentOptions, worker-command polls do not.Why
The test added in #2987 uses an unversioned worker, so the assertions that worker-command polls omit versioning metadata pass trivially — no poll carries versioning info.
How did you test it?
Unit test verified against real server in CI ("Unit test with CLI" job).
🤖 Generated with Claude Code