Skip to content

[SDK Sentinel] Stabilize AsyncPoller suspend polling test #3011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sdk-sentinel-bot wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −1
Draft

[SDK Sentinel] Stabilize AsyncPoller suspend polling test #3011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion temporal-sdk/src/test/java/io/temporal/internal/worker/AsyncPollerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,15 @@ public void testAsyncPollFailed()
@Test
public void testSuspendPolling()
throws InterruptedException, ExecutionException, AsyncPoller.PollTaskAsyncAbort {
CountingSlotSupplier<SlotInfo> slotSupplierInner = new CountingSlotSupplier<>(1);
CountDownLatch reserveAttemptLatch = new CountDownLatch(2);
CountingSlotSupplier<SlotInfo> slotSupplierInner =
new CountingSlotSupplier<SlotInfo>(1) {
@Override
public SlotSupplierFuture reserveSlot(SlotReserveContext<SlotInfo> ctx) throws Exception {
reserveAttemptLatch.countDown();
return super.reserveSlot(ctx);
}
};
TrackingSlotSupplier<?> slotSupplier =
new TrackingSlotSupplier<>(slotSupplierInner, new NoopScope());
DummyTaskExecutor executor = new DummyTaskExecutor(slotSupplier);
Expand Down Expand Up @@ -377,6 +385,9 @@ public void testSuspendPolling()
assertEquals(1, slotSupplierInner.reservedCount.get());
assertEquals(0, slotSupplier.getUsedSlots().size());
});
// Wait until the poll loop is reserving a slot for its next iteration. Suspending before this
// point would correctly prevent that reservation, making the expected count racy.
assertTrue(reserveAttemptLatch.await(5, TimeUnit.SECONDS));
// Suspend polling again, this will not affect the already issued poll request
poller.suspendPolling();
completePoll.get().apply();
Expand Down