Skip to content

[SDK Sentinel] Fix unfinished-handler update race across continue-as-new #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sdk-sentinel-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[SDK Sentinel] Fix unfinished-handler update race across continue-as-new #1757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tests/worker/test_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6845,6 +6845,14 @@ async def _run_workflow_and_get_warning(self) -> bool:
id=workflow_id,
task_queue=task_queue,
)
# Keep the update on the run that receives it so continue-as-new cannot
# make a completion poll look for the update on the successor run.
assert handle.result_run_id
handle = self.client.get_workflow_handle(
workflow_id,
run_id=handle.result_run_id,
first_execution_run_id=handle.first_execution_run_id,
)
if self.workflow_termination_type == "-cancellation-":
await handle.cancel()

Expand Down