Repository navigation
Conversation
Prepared with OpenAI Codex.
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
A synchronous activity can receive cancellation while waiting for an executor thread. The raiser stores the exception, but thread registration never delivers it, so the cancelled activity still executes. Registration now checks the pending exception under the existing lock and honours shielding.
Registration can now raise before the context manager yields, so it also moves inside the existing cleanup guard. The thread id is cleared on that path, keeping the executor thread available for the next activity.
Validation
mainatfc5299b.poe lintpasses (Ruff formatting/imports, Pyright, mypy, basedpyright and docstyle).Python source was tested with Python 3.13.16 and the published 1.33.0 native bridge; no Rust code changes. CI should verify the current bridge build.
Prepared with OpenAI Codex.