Skip to content

docs: import ClientConfig from temporalio.envconfig in README - #1955

Open
shaikn6 wants to merge 1 commit into
temporalio:mainfrom
shaikn6:fix-readme-envconfig-import
Open

shaikn6 wants to merge 1 commit into
temporalio:mainfrom
shaikn6:fix-readme-envconfig-import

Conversation

@shaikn6

@shaikn6 shaikn6 commented Oct 10, 2026

Copy link
Copy Markdown

The environment-configuration example in the README imports ClientConfig from temporalio.client and then calls ClientConfig.load_client_connect_config().

temporalio.client.ClientConfig is the TypedDict of client options and has no load_client_connect_config, so the sample fails with AttributeError. The loader lives on temporalio.envconfig.ClientConfig; the sample now imports it from there and keeps Client on the temporalio.client import.

Checked against the released package: from temporalio.envconfig import ClientConfig; ClientConfig.load_client_connect_config exists, temporalio.client.ClientConfig does not have it. Docs-only change.

@shaikn6
shaikn6 requested a review from a team as a code owner October 10, 2026 17:28
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants