Skip to content

docs: describe logout --revoke across networks and the concurrent-change retry - #280

Merged
brendanjryan merged 2 commits into
mainfrom
brendan/logout-revoke-docs
Oct 19, 2026
Merged

brendanjryan merged 2 commits into
mainfrom
brendan/logout-revoke-docs

Conversation

@brendanjryan

Copy link
Copy Markdown
Contributor

Motivation

The README still says logout --revoke fails with E_USAGE when the logout covers keys on another network. Since the accounts 0.21.0 bump, revocations name their key's chain and logout --revoke revokes keys on every network it covers. The docs also don't mention the retryable error a logout returns when another login or refresh changes the wallet mid-logout.

Summary

  • README: --revoke revokes each key on its own network, including networks the wallet is not logged in on; drop the per-network E_USAGE refusal.
  • README: describe the retryable E_USAGE when a concurrent login or refresh changes the wallet during logout, including that keys already revoked on-chain are removed and named.
  • SKILL.md: same two points in the logout rule, phrased as agent guidance (rerun the logout).

Key design considerations

  • Prose only; generated blocks are unchanged.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T23:21:11.423230Z 18aaeee PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.

Comment thread SKILL.md Outdated

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a docs-only change, and the follow-up commit adds the fresh-approval step before an agent reruns a logout that hit the concurrent-change error.
What was reviewed:

  • Checked the cross-network --revoke claim against src/commands/logout.ts. Keys are revoked on their own chain through one provider (lines 140-141 and 183-188), and the old per-network E_USAGE refusal is no longer in the code.
  • Checked the concurrent-change wording against scopeChanged and its retryable E_USAGE (lines 220-231). Keys that were already revoked are removed and named, and the rerun command keeps --yes, which matches the new SKILL.md text.
  • README.md and SKILL.md agree on both points, and the changelog entry is correctly marked wallet-cli: none.
Extended reasoning...

The change edits prose in README.md and SKILL.md and adds a changelog entry marked none. No code or generated blocks change. Its claims about logout --revoke revoking on each key's own network, and about the retryable E_USAGE after a concurrent login or refresh, match the existing logic in src/commands/logout.ts. Commit 90c8ab7 adds the fresh user approval asked for in the earlier inline comment. There are no CODEOWNERS files and no objections from other reviewers.

@brendanjryan

Copy link
Copy Markdown
Contributor Author

+1

@tempo-voight-kampff tempo-voight-kampff Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of @brendanjryan, who approved this pull request (head 90c8ab720124) with a +1 comment via Voight-Kampff.

GitHub branch protection considers pull request reviews, not +1 comments. Voight-Kampff is recording this approval on the reviewer's behalf so branch protection requirements are met.

@brendanjryan
brendanjryan merged commit cc58713 into main Oct 19, 2026
23 checks passed
@brendanjryan
brendanjryan deleted the brendan/logout-revoke-docs branch October 19, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant