Repository navigation
docs: describe logout --revoke across networks and the concurrent-change retry - #280
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
LGTM. This is a docs-only change, and the follow-up commit adds the fresh-approval step before an agent reruns a logout that hit the concurrent-change error.
What was reviewed:
- Checked the cross-network
--revokeclaim against src/commands/logout.ts. Keys are revoked on their own chain through one provider (lines 140-141 and 183-188), and the old per-networkE_USAGErefusal is no longer in the code. - Checked the concurrent-change wording against
scopeChangedand its retryableE_USAGE(lines 220-231). Keys that were already revoked are removed and named, and the rerun command keeps--yes, which matches the new SKILL.md text. - README.md and SKILL.md agree on both points, and the changelog entry is correctly marked
wallet-cli: none.
Extended reasoning...
The change edits prose in README.md and SKILL.md and adds a changelog entry marked none. No code or generated blocks change. Its claims about logout --revoke revoking on each key's own network, and about the retryable E_USAGE after a concurrent login or refresh, match the existing logic in src/commands/logout.ts. Commit 90c8ab7 adds the fresh user approval asked for in the earlier inline comment. There are no CODEOWNERS files and no objections from other reviewers.
|
+1 |
There was a problem hiding this comment.
Approving on behalf of @brendanjryan, who approved this pull request (head 90c8ab720124) with a +1 comment via Voight-Kampff.
GitHub branch protection considers pull request reviews, not +1 comments. Voight-Kampff is recording this approval on the reviewer's behalf so branch protection requirements are met.
Motivation
The README still says
logout --revokefails withE_USAGEwhen the logout covers keys on another network. Since the accounts 0.21.0 bump, revocations name their key's chain andlogout --revokerevokes keys on every network it covers. The docs also don't mention the retryable error a logout returns when another login or refresh changes the wallet mid-logout.Summary
--revokerevokes each key on its own network, including networks the wallet is not logged in on; drop the per-networkE_USAGErefusal.E_USAGEwhen a concurrentloginorrefreshchanges the wallet during logout, including that keys already revoked on-chain are removed and named.Key design considerations