Repository navigation
Gracefully handle missing tf-estimator on TensorFlow 2.16+ (fixes #611) - #651
Open
laasyapriya2007 wants to merge 1 commit into
Open
laasyapriya2007 wants to merge 1 commit into
laasyapriya2007 wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #611 (and resolves #597).
In TensorFlow 2.16+,
tf-estimatorhas been deprecated and its distributor hooks (estimator_training) removed fromtensorflow.python.distribute.Previously,
tensorflow_privacy/__init__.pyandtensorflow_privacy/v1/__init__.pyunconditionally importedDNNClassifierandDNNClassifierV1, which causedimport tensorflow_privacyto crash immediately on TensorFlow 2.16+ (including 2.18.0) even when the user only intended to use DP-SGD, KerasDPModel, DP queries, or privacy analysis tools.Changes
try...except (ImportError, AttributeError)fallback logic when importingDNNClassifierandDNNClassifierV1.tf-estimatoris unavailable, instantiating the stub provides an informativeRuntimeErrorexplaining the deprecation and guiding users to migrate to Keras-based DP models (DPModel/DPSequential).Testing
import tensorflow_privacyandimport tensorflow_privacy.v1succeed in both standard environments and whentensorflow_estimatoris simulated as missing/deprecated.compute_dp_sgd_privacy_test.pycontinue to pass.