chore: update dependencies - #602
Merged
Merged
Conversation
Bump Angular to 22.1.6 (CLI 22.1.8, CDK/Material 22.1.7), angular-eslint to 22.5, typescript-eslint to 8.70, jest to 30.5.1, vitest to 4.1.11 and the usual patch/minor bumps. Major bumps: eslint 10, @ngrx/store 22, @testing-library/jest-dom 7, jsdom 29, lint-staged 17, cpy-cli 7. ESLint 10 no longer ships @eslint/js as a transitive dependency, so it is added explicitly for the import in eslint.config.mjs. jsdom is kept at 29 rather than 30: jsdom 30 enforces the receiver check on CSS.escape, which breaks the detached reference held by jest-dom's css.escape polyfill and fails the toHaveFormValues tests under vitest. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Dependency update round in
package.json(no lockfile in this repo).Minor/patch bumps: Angular 22.1.1 → 22.1.6, CDK/Material → 22.1.7, CLI/devkit/schematics → 22.1.8, angular-eslint 22.1 → 22.5, typescript-eslint 8.67 → 8.70, jest 30.4 → 30.5.1, vitest 4.1.10 → 4.1.11, plus small bumps to zone.js, user-event, dom, autoprefixer, ng-mocks, prettier,
@types/node, karma-jasmine-html-reporter and@eslint/eslintrc.Major bumps (all checked against their peer ranges):
eslint9 → 10 — every plugin in the config already declares^10support@ngrx/store21 → 22 — peers on@angular/core ^22@testing-library/jest-dom6 → 7 — only breaking changes are Node ≥ 22 and@testing-library/domas a required peer, both already satisfiedjsdom27 → 29 (deliberately not 30, see below)lint-staged16 → 17,cpy-cli6 → 7New devDependency:
@eslint/js. ESLint 10 dropped it from its own dependencies, so the existingimport eslint from '@eslint/js'ineslint.config.mjsstopped resolving andng lintfailed until it was added explicitly.Reviewer notes
toHaveFormValuestests in the vitest example app fail with'escape' called on an object that is not a valid instance of CSS. jest-dom'scss.escapepolyfill grabsCSS.escapedetached fromCSS, and jsdom 30 enforces the receiver check. Verified 27.4 / 28.1 / 29.1.1 pass and 30.0.1 fails; jest-dom 6 vs 7 makes no difference. The fix belongs upstream incss.escape/ jest-dom — worth rechecking next round.typescript6.0.x (Angular 22.1 + ng-packagr pin>=6.0 <6.1),vitest4.x (@angular/buildpeers on^4),jasmine-core/@types/jasmine4 (karma-jasmine5.1 bundles jasmine-core^4).^6.9.1jest-dom version theng-addschematic installs for users is untouched; that's a separate, user-facing decision.Verification
Run locally on Node 24.15 with a clean
npm install --force(same as CI):npm run build✅npm run lint✅ (all four projects on ESLint 10)npm run format:check✅npm run test:testing-library✅ 155/155npm run test:example-app✅ 55/55npm run test:jest-app✅ 53 passed, 3 skippednpm run test:karma-app -- --watch=false✅ 5/5🤖 Generated with Claude Code