Skip to content

fix: preserve reactStrictMode when configure() omits it #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nimbly1 wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

fix: preserve reactStrictMode when configure() omits it #1474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/__tests__/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,17 @@ describe('configuration API', () => {

expect(getConfig().reactStrictMode).toBe(true)
})

test('configure without reactStrictMode preserves the existing value', () => {
configure({reactStrictMode: true})
configure({testIdAttribute: 'not-data-testid'})

expect(getConfig().reactStrictMode).toBe(true)

configure({reactStrictMode: false})

expect(getConfig().reactStrictMode).toBe(false)
})
})

test('configure can set DTL and RTL options at once', () => {
Expand Down
4 changes: 3 additions & 1 deletion src/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ function configure(newConfig) {

configForRTL = {
...configForRTL,
reactStrictMode,
// Only overwrite the existing value when a new one is provided,
// so calling configure() for other options keeps reactStrictMode.
reactStrictMode: reactStrictMode ?? configForRTL.reactStrictMode,
}
}

Expand Down
Loading