Fix stitched note next to the Enable Tunnel checkbox#38
Merged
Conversation
The freestyle Build Environment wrapper rendered a <small> note inline right after the 'Enable TestingBot Tunnel?' checkbox label (inside an f:block), so the text ran straight into the label with no spacing, and it duplicated the ? help icon already on the field. Remove the inline note (and a pointless f:optionalBlock wrapper) and fold the hint into help-useTunnel.html instead. The checkbox still binds to useTunnel and shows its saved state.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe pull request simplifies the ChangesuseTunnel UI
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In the freestyle Build Environment config, the "Skip this if you are using TestingBot Tunnel in your code" note was rendered as an inline
<small>(inside an<f:block>) right after the Enable TestingBot Tunnel? checkbox — so it ran straight into the label with no spacing, and it duplicated the?help icon already on the field.Fix
<f:optionalBlock>wrapper; the field is now a plain<f:checkbox>.help-useTunnel.html(the?icon).Validation
mvn -DskipTests verifyclean; jelly well-formed. Viahpi:run+ a rendered capture: the checkbox now shows a clean label +?icon with no stitched text, and it still binds touseTunnel(renders checked when the job has it enabled).Summary by CodeRabbit
New Features
Documentation