refactor: style-rule cleanup in isolated files (plan 016, partial)#94
Open
DavertMik wants to merge 1 commit into
Open
refactor: style-rule cleanup in isolated files (plan 016, partial)#94DavertMik wants to merge 1 commit into
DavertMik wants to merge 1 commit into
Conversation
Only the items in files untouched by the other open refactor PRs, so this
does not conflict with them:
- fisherman-tools: `value === null || value === undefined` -> `value == null`
(0/''/false are valid field values, so not `!value`)
- quartermaster: move the 4 interfaces to end of file; outputPath('a11y')
instead of join(getOutputDir(), 'a11y'); drop the existsSync guard
(mkdirSync recursive tolerates existing) and inline ensureDirectory away.
The bulk of plan 016 (private-method reordering, type-moves, ternary and
conditional-spread cleanups across tester/tools/provider/pilot/etc.) is
DEFERRED: 016 is the run-last plan and pure-move reorderings conflict with
every open PR. It should run after #85-#93 land.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Explorbot Self-RegressionCommit
Attempt details
Session analysis — basic (native): Session AnalysisThe issue tracking feature set was exercised across 5 test scenarios covering create, search, filter by label, filter by status, and view details. All core flows completed successfully with proper UI feedback. The only notable observation is inconsistent logging in one test that does not affect the outcome. Coverage
What works
|
DenysKuchma
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan 016 — Mechanical style batch (PARTIAL — see deferral)
Plan 016 is the run-last style sweep (private-method reordering, types-at-end, ternary/conditional-spread removal across ~20 core files). Its own dependency: "run last to avoid merge churn — pure-move reorderings conflict with every other diff."
All six of this session's refactor PRs (#88–#93) plus #85/#86/#87 are still open and touch nearly every file 016 targets. Doing the reordering now would conflict with all of them. So this PR does only the items in files that no open PR touches, and defers the rest until the batch merges.
Done here (non-conflicting)
fisherman-tools.ts:value === null || value === undefined→value == null(kept== nullrather than!valuebecause0/''/falseare valid field values).quartermaster.ts: 4 interfaces moved to end of file (CLAUDE.md "types at end");outputPath('a11y')instead ofjoin(configParser.getOutputDir(), 'a11y'); dropped theexistsSyncguard (mkdirSyncrecursive tolerates an existing dir) and inlinedensureDirectoryaway.Deferred (until #85–#93 merge)
Private-method reordering, type-moves, and the ternary/conditional-spread/one-liner cleanups in tester, tools, provider, pilot, driller, conversation, planner, researcher, captain, experience-tracker, experience-compactor, state-manager, explorer, etc. — every one of those files is modified by an open PR, so 016's reorderings must wait to avoid conflicts.
Verification
bun test tests/unit→ 764 pass / 0 fail;bun test tests/integration/→ 63 pass / 0 fail.bun run lint→ clean;tscno new errors in the touched files.🤖 Generated with Claude Code