Run CI tests on all operating systems#17
Conversation
|
@Ao-chuba With this PR the tests run on all operating systems, and there was one similar issue on macOS that required relaxing a threshold in the unit tests, similar to what you described but for a different test. Based on these observations, it seems that OpenBLAS is causing the difference, or not? I don't have much experience with it. Do you know how it can be used in a GitHub Action? |
|
@tovrstra |
|
@Ao-chuba I've included the NumPy and SciPy config outputs in the GH Action to allow for a better comparison with your local installation, see https://github.com/theochem/tinydft/actions/runs/24385878928/job/71219495810?pr=17#step:6:1 Can you compare the outputs of the following commands with the ones from the CI to see where they differ? python -c "import numpy; numpy.show_config()"
python -c "import scipy; scipy.show_config()"The CI on Windows also uses a NumPy linked to OpenBLAS, so there should be another explanation for the discrepancy. Thanks! |
|
@tovrstra |
|
Thanks for bringing up CPU architecture. I don't have access to that specific CPU, but I tried a few other ones for comparison, all with Linux.
It seems fine most of the time, except for some unlucky CPUs, so there is no hope that we can catch such problems in a GitHub Action systematically. I guess the best we can do is carefully increase thresholds and add comments for which CPU architecture the threshold was increased. It's probably also good to add a note to the README that this is a known issue. Can you install the |
|
@tovrstra |
|
Thresholds were updated with comments on CPUs. @Ao-chuba Can you confirm that all tests pass on your laptop too? |
|
@tovrstra |
|
Thanks. Time to merge... |

This PR extends the continuous integration to Windows and macOS. The initial commit is minimal and more changes may be required to pass all tests, in line with issue #16.