Implement clang-format#107
Draft
L1ghtmann wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Implements a .clang-format file and does a first pass. Based largely on discussion in #24 and #20. Based on WebKit clang-format.
Checklist
@import MyLibrary;in ObjC, orimport MyLibraryin Swift.Does this close any currently open issues?
Will eventually resolve #24
Any relevant logs, error output, etc?
Any other comments?
Most edits appear to be a tab->space conversion or destruction of
#defineformatting. I was unable to find a way to enforce our apparent preference there, but I am quite unfamiliar with header formatting and the various specs/associated tooling.Changes and opinions are more than welcome! Just wanted to get the ball rolling.
Additionally, we will want to apply an exclusion list (comprised of Apple headers, etc) if/when we implement this into a workflow, as we do for compilation now.
Where has this been tested?
Operating System: …
Platform: …
Target Platform: …
Toolchain Version: …
SDK Version: …