Update AbstractProvider.php - Fixing return type as Psalm complains a…#1009
Open
michelgokan wants to merge 4 commits intothephpleague:masterfrom
Open
Update AbstractProvider.php - Fixing return type as Psalm complains a…#1009michelgokan wants to merge 4 commits intothephpleague:masterfrom
michelgokan wants to merge 4 commits intothephpleague:masterfrom
Conversation
…bout it It seems like this function is returning an instance of type AccessToken instead of AccessTokenInterface. The latest version of `psalm` is complaining about this issue.
ramsey
reviewed
Dec 10, 2024
| * @param array $response | ||
| * @param AbstractGrant $grant | ||
| * @return AccessTokenInterface | ||
| * @return AccessToken |
Contributor
There was a problem hiding this comment.
Since AccessToken implements AccessTokenInterface, I don't understand why Psalm would complain about this.
Is this still a problem in the latest version of Psalm?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1009 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 193 193
===========================================
Files 20 20
Lines 519 519
===========================================
Hits 519 519
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…bout it
This function returns an instance of type AccessToken instead of AccessTokenInterface. The latest version of
psalmis complaining about this issue.