ASoC: SOF: Use high-priority workqueue for PCM period elapsed#5781
Open
poloo5582 wants to merge 1 commit into
Open
ASoC: SOF: Use high-priority workqueue for PCM period elapsed#5781poloo5582 wants to merge 1 commit into
poloo5582 wants to merge 1 commit into
Conversation
The snd_sof_pcm_period_elapsed function currently schedules work on the
system-wide workqueue. This can lead to potential delays or jitter in
audio processing if the system workqueue is busy with other tasks.
To improve real-time performance and ensure timely processing of PCM
periods, create a dedicated high-priority, unbound workqueue
("sof_pcm_wq") specifically for this purpose.
Update the period elapsed handling to queue work onto this new
workqueue, while maintaining a fallback to the system workqueue if the
dedicated one is not initialized.
Signed-off-by: Yu-Hsuan Hsu <yuhsuan@google.com>
poloo5582
requested review from
dbaluta,
lyakh,
plbossart and
ranj063
as code owners
ujfalusi
reviewed
May 22, 2026
| mutex_init(&sdev->dsp_fw_boot_mutex); | ||
|
|
||
| /* Create high-priority workqueue for PCM period elapsed work */ | ||
| sdev->pcm_period_wq = alloc_workqueue("sof_pcm_wq", WQ_HIGHPRI | WQ_UNBOUND, 0); |
Collaborator
There was a problem hiding this comment.
Can you describe how this can happen?
If the system workqueue is that much congested then how can anything work?
We use threaded irq as well and that is also using system queue afaik, I'm not sure how this helps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The snd_sof_pcm_period_elapsed function currently schedules work on the system-wide workqueue. This can lead to potential delays or jitter in audio processing if the system workqueue is busy with other tasks.
To improve real-time performance and ensure timely processing of PCM periods, create a dedicated high-priority, unbound workqueue ("sof_pcm_wq") specifically for this purpose.
Update the period elapsed handling to queue work onto this new workqueue, while maintaining a fallback to the system workqueue if the dedicated one is not initialized.