Repository navigation
fix(lang-core): report empty index expressions as parser errors - #1279
Closed
AbhinRustagi wants to merge 2 commits into
Closed
AbhinRustagi wants to merge 2 commits into
AbhinRustagi wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Moved the parser fix, correction examples, and patch changeset into #1268. Closing this duplicate PR; the changes will ship with the renderer work. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated chart expressions such as
metrics.daily[].daysilently evaluated to null, leaving charts blank while parser validation reported success. Report these asinvalid-expressionerrors with the statement ID and guidance to usemetrics.daily.dayfor array projection.Both one-shot and streaming parsers surface the error. Automatically closed unfinished indexes remain tolerated, and a later replacement statement clears its old diagnostics. Includes a patch changeset and updates the validation-error counters.
Validation: lang-core build and typecheck; all 115 existing tests; inline regression checks for raw/nested empty indexes, valid indexes/projections/empty arrays, chunked streaming, and corrective patches. Verified Muse's existing
assertValidOpenUILangrejects the malformed expression and accepts its correction using the built package. No Muse dependency change or package publication is included.