Skip to content

fix: migrate to the official phpMyAdmin Docker image - #4828

Merged
thorsten merged 1 commit into
thorsten:mainfrom
williamdes:phpmyadmin-official-image
Oct 30, 2026
Merged

thorsten merged 1 commit into
thorsten:mainfrom
williamdes:phpmyadmin-official-image

Conversation

@williamdes

@williamdes williamdes commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The Docker Compose file pulled phpmyadmin/phpmyadmin:5. The phpMyAdmin project is deprecating that repository in favour of the official image phpmyadmin, and the legacy one no longer receives the PHP base image rebuilds that carry the current CVE fixes.

phpmyadmin/phpmyadmin:5 → phpmyadmin:5. The 5 rollup tag exists in the official image, so the pinned major version is unchanged and the resolved image is the same release line.

Checklist

  • composer check passes (format, lint, static analysis)
  • composer test and pnpm test pass
  • pnpm tsc and pnpm oxlint pass for TypeScript changes
  • New or changed behaviour is covered by tests
  • Database schema changes ship with an upgrade step in phpMyFAQ\Setup\Update
  • CHANGELOG.md is updated for user-facing changes
  • Dependency major version bumps: upstream changelog read, old APIs grepped for, build green

Left unticked deliberately: this only changes an image reference in docker-compose.yml. No PHP, TypeScript or schema code is touched, so composer check, composer test and the TS checks do not exercise it, and I cannot claim to have run them here. Say the word if you want a CHANGELOG.md entry and I will add one.

This change was prepared with the assistance of the DeepSeek model.

Summary by CodeRabbit

  • Chores
    • Updated the phpMyAdmin service to use a different image source while keeping it on the same major version. No changes to the application’s user-facing features are included in this update.

See: phpmyadmin/docker#363
Signed-off-by: William Desportes <williamdes@wdes.fr>
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 91cebeed-52ed-48a8-96ec-2f679a8bcc5e
Commits

Reviewing files that changed from the base of the PR and between dfa6771 and 0cea80d.

Files selected for processing: 1
  • docker-compose.yml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

The phpmyadmin service in docker-compose.yml now uses the phpmyadmin:5 image.

Changes: phpMyAdmin image configuration

Layer / File(s) Summary
Update phpMyAdmin image reference
docker-compose.yml
The phpmyadmin service image changes from phpmyadmin/phpmyadmin:5 to phpmyadmin:5.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: thorsten

Merge Risk: Minimal · up to 0cea8

No actionable merge-blocking risk is established for this isolated image-reference update.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the change from the legacy phpMyAdmin Docker image reference to the official image.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thorsten
thorsten merged commit c39faad into thorsten:main Oct 30, 2026
10 of 11 checks passed
@williamdes
williamdes deleted the phpmyadmin-official-image branch October 30, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants