SCAL-331020: Add Spotter analyst list/default actions and analystId config - #619
Open
bahetirisabh wants to merge 4 commits into
Open
SCAL-331020: Add Spotter analyst list/default actions and analystId config#619bahetirisabh wants to merge 4 commits into
bahetirisabh wants to merge 4 commits into
Conversation
…onfig
Add two Action enum members, SpotterAnalystList and SpotterDefaultAnalyst,
so hosts can control the analyst list ("Show all") and the default Spotter
analyst entry with types and autocomplete instead of raw strings. These flow
through the existing hiddenActions/disabledActions/visibleActions arrays, so
no new plumbing is required.
Add analystId to SpotterEmbedViewConfig, serialized into the iframe URL via
the new Param.AnalystId so the FE can read it off embedParams. Setting it
pins the embed to a single spotter analyst, implying no default Spotter and
no "Show all".
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
commit: |
Picks up SpotterAnalystList, SpotterDefaultAnalyst and SpotterEmbedViewConfig.analystId. Also picks up drift already on main whose commits did not regenerate the docs: preRenderConfig from thoughtspot#603, and the enum-name corrections from thoughtspot#615 (EmbedEvent.customAction -> CustomAction, EmbedEvent.DrillDown -> Drilldown, ListPageColumns.Favorite -> Favorites, AuthEvent.SUCCESS -> AuthStatus.SUCCESS, and the removal of the non-existent HostEvent.ScheduleList examples). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
somechandra-thoughtspot
previously approved these changes
Aug 11, 2026
Replaces the flat SpotterEmbedViewConfig.analystId with spotterAnalystConfig?: SpotterAnalystConfig, matching the existing spotterChatConfig / spotterSidebarConfig grouping so future analyst settings have a home instead of accumulating at the top level. Consumption is unchanged: the value is still serialized as the analystId query param, so the FE keeps reading embedParams.analystId. SpotterAnalystConfig is defined in conversation.ts alongside the other Spotter sub-configs and exported from index.ts. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
# Conflicts: # static/typedoc/typedoc.json
adityamittal3107
approved these changes
Aug 13, 2026
somechandra-thoughtspot
approved these changes
Aug 13, 2026
|
|
||
| it('should render the conversation embed with spotterAnalystConfig.analystId in the url', async () => { | ||
| const viewConfig: SpotterEmbedViewConfig = { | ||
| worksheetId: 'worksheetId', |
There was a problem hiding this comment.
Worksheets are deprecated and changed with model, do we still need to use the worksheet keyword?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two additions for the Spotter Analyst experience, targeting ThoughtSpot 26.10.0.cl / SDK 1.53.0.
1. Two new
Actionenum membersThey control the analyst list ("Show all") and the default Spotter analyst entry. These flow through the existing
hiddenActions/disabledActions/visibleActionsarrays, so there is no new plumbing — the enum entries just give hosts types and autocomplete instead of raw strings.2. New
SpotterAnalystConfigonSpotterEmbedViewConfigUsed as
spotterAnalystConfig?: SpotterAnalystConfigon the view config:Grouping it into an object matches the existing
spotterChatConfig/spotterSidebarConfigpattern, so future analyst settings have a home instead of accumulating at the top level. It is defined inconversation.tsnext to the other Spotter sub-configs and exported fromindex.ts.Consumption is unchanged. The value is serialized as the
analystIdquery param viaParam.AnalystId, so the FE readsembedParams.analystIdexactly as before.setParamIfDefinedomits it when unset, so the URL is unchanged for hosts that don't use it — including whenspotterAnalystConfig: {}is passed with noanalystId.Note on the typedoc diff
static/typedoc/typedoc.jsonis regenerated vianpm run docgen. The diff is large, but nearly all of it is mechanicalidrenumbering andlineshifts caused by inserting symbols intotypes.tsandconversation.ts.mainwas merged in and the generated file was resolved by regenerating from the merged source rather than hand-merging. Verified againstorigin/main:SpotterAnalystList,SpotterDefaultAnalyst,SpotterAnalystConfig,spotterAnalystConfig,analystIdTest plan
analystId: present whenspotterAnalystConfig.analystIdis set, absent when the config is omitted, and absent when the config is an empty object.it.eachtables inconversation.spec.ts.main: 44/44 suites, 1653 passed, 4 skipped.tsc --noEmitandeslintclean on all changed files.