Skip to content

Fix nuxt/nextjs E2E flakiness and align CI step naming - #87

Merged
brionmario merged 1 commit into
thunder-id:mainfrom
janithjay:fix-nuxt-nextjs-e2e-timeouts
Aug 20, 2026
Merged

Fix nuxt/nextjs E2E flakiness and align CI step naming#87
brionmario merged 1 commit into
thunder-id:mainfrom
janithjay:fix-nuxt-nextjs-e2e-timeouts

Conversation

@janithjay

@janithjay janithjay commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Purpose

CI showed intermittent failures on the nuxt-quickstart and nextjs-quickstart E2E suites.

Root-caused it: the redirect landing page is server-rendered, so the user dropdown trigger can be visible before React/Vue finishes attaching its click handler. Under CI-level CPU contention that gap is wide enough to swallow the first click entirely no error, just a menu item that never appears and a test that hangs until timeout

Approach

  • tests/e2e/pages/thunderid-web-sample.page.ts: added a private openDropdown() helper used by logout(), openTokenDebug(), and openManageProfile(). It clicks the trigger, verifies the target menu item actually appeared, and retries the click (up to 3x) if it didn't. This fixes the race at its source instead of papering over it with a bigger timeout.

  • .github/workflows/pr-builder.yml, .github/actions/run-e2e-suite/action.yml: retitled the E2E job/step names to the Title Case convention.

Related Issues

  • N/A

Related PRs

Checklist

  • Followed the contribution guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Tests provided. (Add links if there are any)
    • Unit Tests
    • Integration Tests
  • Breaking changes. (Fill if applicable)
    • Breaking changes section filled.
    • breaking change label added.

Security checks

  • Followed secure coding standards.
  • Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.

Copilot AI lite review requested due to automatic review settings August 20, 2026 05:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 864ffdc4-d14c-4d40-aae4-dfc7404dc3af


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@janithjay
janithjay marked this pull request as draft August 20, 2026 05:32
Signed-off-by: janithjay <janithjayashan018@gmail.com>
@janithjay
janithjay force-pushed the fix-nuxt-nextjs-e2e-timeouts branch from 43a034e to 812c40f Compare August 20, 2026 07:19
@janithjay
janithjay marked this pull request as ready for review August 20, 2026 07:43
@brionmario
brionmario merged commit cd30859 into thunder-id:main Aug 20, 2026
6 checks passed
@janithjay
janithjay deleted the fix-nuxt-nextjs-e2e-timeouts branch August 20, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants