Skip to content

NetworkPkg/HttpBootDxe: Add all events to HttpBootHttpCallback()#12412

Open
SaloniKasbekar wants to merge 2 commits intotianocore:masterfrom
SaloniKasbekar:master
Open

NetworkPkg/HttpBootDxe: Add all events to HttpBootHttpCallback()#12412
SaloniKasbekar wants to merge 2 commits intotianocore:masterfrom
SaloniKasbekar:master

Conversation

@SaloniKasbekar
Copy link
Copy Markdown
Contributor

Include other events from EDKII_HTTP_CALLBACK_EVENT to print failure information in the event of HTTP Boot failure

Description

Add other non-TLS events to the print failure information during HTTP Boot flow for better end user experience

  • Breaking change?

  • Impacts security?

  • Includes tests?

How This Was Tested

Verified failure prints during HTTP Boot flow

Integration Instructions

N/A

Comment thread NetworkPkg/HttpBootDxe/HttpBootImpl.c
Include other events from EDKII_HTTP_CALLBACK_EVENT to print failure
information in the event of HTTP Boot failure

Signed-off-by: Saloni Kasbekar <saloni.kasbekar@intel.com>
Comment thread NetworkPkg/HttpBootDxe/HttpBootImpl.c
@mergify mergify bot added the queued label Apr 11, 2026
@mergify
Copy link
Copy Markdown

mergify bot commented Apr 11, 2026

Merge Queue Status

  • Entered queue2026-04-11 00:40 UTC · Rule: default
  • Checks started · in-place
  • 🚫 Left the queue2026-04-11 00:42 UTC · at 31c138cc8b5aef55c2ab17717bd05199d8333b28

This pull request spent 2 minutes 4 seconds in the queue, including 8 seconds running CI.

Waiting for:

  • #approved-reviews-by >= 1
  • any of:
    • check-neutral = tianocore.PatchCheck
    • check-skipped = tianocore.PatchCheck
    • check-success = tianocore.PatchCheck
  • any of:
    • check-neutral = ArmVirtPkg - Ubuntu GCC - PR
    • check-skipped = ArmVirtPkg - Ubuntu GCC - PR
    • check-success = ArmVirtPkg - Ubuntu GCC - PR
  • any of:
    • check-neutral = EmulatorPkg - Ubuntu GCC - PR
    • check-skipped = EmulatorPkg - Ubuntu GCC - PR
    • check-success = EmulatorPkg - Ubuntu GCC - PR
  • any of:
    • check-neutral = EmulatorPkg - Windows VS - PR
    • check-skipped = EmulatorPkg - Windows VS - PR
    • check-success = EmulatorPkg - Windows VS - PR
  • any of:
    • check-neutral = OvmfPkg - Ubuntu GCC - PR
    • check-skipped = OvmfPkg - Ubuntu GCC - PR
    • check-success = OvmfPkg - Ubuntu GCC - PR
  • any of:
    • check-neutral = OvmfPkg - Windows VS - PR
    • check-skipped = OvmfPkg - Windows VS - PR
    • check-success = OvmfPkg - Windows VS - PR
  • any of:
    • check-neutral = Windows VS - PR
    • check-skipped = Windows VS - PR
    • check-success = Windows VS - PR
  • any of:
    • check-neutral = Ubuntu GCC - PR
    • check-skipped = Ubuntu GCC - PR
    • check-success = Ubuntu GCC - PR
  • any of:
    • check-neutral = Validate Pull Request Formatting
    • check-skipped = Validate Pull Request Formatting
    • check-success = Validate Pull Request Formatting
  • any of:
    • check-neutral = ArmVirtPkg - Ubuntu - CLANGPDB
    • check-skipped = ArmVirtPkg - Ubuntu - CLANGPDB
    • check-success = ArmVirtPkg - Ubuntu - CLANGPDB
  • any of:
    • check-neutral = OvmfPkg - Ubuntu - CLANGPDB
    • check-skipped = OvmfPkg - Ubuntu - CLANGPDB
    • check-success = OvmfPkg - Ubuntu - CLANGPDB
  • any of:
    • check-neutral = Ubuntu - CLANGPDB
    • check-skipped = Ubuntu - CLANGPDB
    • check-success = Ubuntu - CLANGPDB
  • any of:
    • check-neutral = Windows - CLANGPDB
    • check-skipped = Windows - CLANGPDB
    • check-success = Windows - CLANGPDB
  • any of:
    • check-neutral = EmulatorPkg - Windows - CLANGPDB
    • check-skipped = EmulatorPkg - Windows - CLANGPDB
    • check-success = EmulatorPkg - Windows - CLANGPDB
All conditions
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-neutral = tianocore.PatchCheck
    • check-skipped = tianocore.PatchCheck
    • check-success = tianocore.PatchCheck
  • any of [🛡 GitHub branch protection]:
    • check-neutral = ArmVirtPkg - Ubuntu GCC - PR
    • check-skipped = ArmVirtPkg - Ubuntu GCC - PR
    • check-success = ArmVirtPkg - Ubuntu GCC - PR
  • any of [🛡 GitHub branch protection]:
    • check-neutral = EmulatorPkg - Ubuntu GCC - PR
    • check-skipped = EmulatorPkg - Ubuntu GCC - PR
    • check-success = EmulatorPkg - Ubuntu GCC - PR
  • any of [🛡 GitHub branch protection]:
    • check-neutral = EmulatorPkg - Windows VS - PR
    • check-skipped = EmulatorPkg - Windows VS - PR
    • check-success = EmulatorPkg - Windows VS - PR
  • any of [🛡 GitHub branch protection]:
    • check-neutral = OvmfPkg - Ubuntu GCC - PR
    • check-skipped = OvmfPkg - Ubuntu GCC - PR
    • check-success = OvmfPkg - Ubuntu GCC - PR
  • any of [🛡 GitHub branch protection]:
    • check-neutral = OvmfPkg - Windows VS - PR
    • check-skipped = OvmfPkg - Windows VS - PR
    • check-success = OvmfPkg - Windows VS - PR
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Windows VS - PR
    • check-skipped = Windows VS - PR
    • check-success = Windows VS - PR
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Ubuntu GCC - PR
    • check-skipped = Ubuntu GCC - PR
    • check-success = Ubuntu GCC - PR
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Validate Pull Request Formatting
    • check-skipped = Validate Pull Request Formatting
    • check-success = Validate Pull Request Formatting
  • any of [🛡 GitHub branch protection]:
    • check-neutral = ArmVirtPkg - Ubuntu - CLANGPDB
    • check-skipped = ArmVirtPkg - Ubuntu - CLANGPDB
    • check-success = ArmVirtPkg - Ubuntu - CLANGPDB
  • any of [🛡 GitHub branch protection]:
    • check-neutral = OvmfPkg - Ubuntu - CLANGPDB
    • check-skipped = OvmfPkg - Ubuntu - CLANGPDB
    • check-success = OvmfPkg - Ubuntu - CLANGPDB
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Ubuntu - CLANGPDB
    • check-skipped = Ubuntu - CLANGPDB
    • check-success = Ubuntu - CLANGPDB
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Windows - CLANGPDB
    • check-skipped = Windows - CLANGPDB
    • check-success = Windows - CLANGPDB
  • any of [🛡 GitHub branch protection]:
    • check-neutral = EmulatorPkg - Windows - CLANGPDB
    • check-skipped = EmulatorPkg - Windows - CLANGPDB
    • check-success = EmulatorPkg - Windows - CLANGPDB
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]

Reason

Pull request #12412 has been dequeued

queue conditions no longer match:

  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • label=push
  • any of [🛡 GitHub branch protection]:
    • check-neutral = tianocore.PatchCheck
    • check-skipped = tianocore.PatchCheck
    • check-success = tianocore.PatchCheck
  • any of [🛡 GitHub branch protection]:
    • check-neutral = ArmVirtPkg - Ubuntu GCC - PR
    • check-skipped = ArmVirtPkg - Ubuntu GCC - PR
    • check-success = ArmVirtPkg - Ubuntu GCC - PR
  • any of [🛡 GitHub branch protection]:
    • check-neutral = EmulatorPkg - Ubuntu GCC - PR
    • check-skipped = EmulatorPkg - Ubuntu GCC - PR
    • check-success = EmulatorPkg - Ubuntu GCC - PR
  • any of [🛡 GitHub branch protection]:
    • check-neutral = EmulatorPkg - Windows VS - PR
    • check-skipped = EmulatorPkg - Windows VS - PR
    • check-success = EmulatorPkg - Windows VS - PR
  • any of [🛡 GitHub branch protection]:
    • check-neutral = OvmfPkg - Ubuntu GCC - PR
    • check-skipped = OvmfPkg - Ubuntu GCC - PR
    • check-success = OvmfPkg - Ubuntu GCC - PR
  • any of [🛡 GitHub branch protection]:
    • check-neutral = OvmfPkg - Windows VS - PR
    • check-skipped = OvmfPkg - Windows VS - PR
    • check-success = OvmfPkg - Windows VS - PR
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Windows VS - PR
    • check-skipped = Windows VS - PR
    • check-success = Windows VS - PR
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Ubuntu GCC - PR
    • check-skipped = Ubuntu GCC - PR
    • check-success = Ubuntu GCC - PR
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Validate Pull Request Formatting
    • check-skipped = Validate Pull Request Formatting
    • check-success = Validate Pull Request Formatting
  • any of [🛡 GitHub branch protection]:
    • check-neutral = ArmVirtPkg - Ubuntu - CLANGPDB
    • check-skipped = ArmVirtPkg - Ubuntu - CLANGPDB
    • check-success = ArmVirtPkg - Ubuntu - CLANGPDB
  • any of [🛡 GitHub branch protection]:
    • check-neutral = OvmfPkg - Ubuntu - CLANGPDB
    • check-skipped = OvmfPkg - Ubuntu - CLANGPDB
    • check-success = OvmfPkg - Ubuntu - CLANGPDB
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Ubuntu - CLANGPDB
    • check-skipped = Ubuntu - CLANGPDB
    • check-success = Ubuntu - CLANGPDB
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Windows - CLANGPDB
    • check-skipped = Windows - CLANGPDB
    • check-success = Windows - CLANGPDB
  • any of [🛡 GitHub branch protection]:
    • check-neutral = EmulatorPkg - Windows - CLANGPDB
    • check-skipped = EmulatorPkg - Windows - CLANGPDB
    • check-success = EmulatorPkg - Windows - CLANGPDB

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

@mergify mergify bot added dequeued and removed queued labels Apr 11, 2026
@SaloniKasbekar
Copy link
Copy Markdown
Contributor Author

@mdkinney @makubacki Could you help review/push this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants