Last LBA missed on NvmExpressMediaClear

[spbrogan]

Off by one error in the code of NvmExpressMediaClear() causes the last LBA to be missed when clearing the media. This patch fixes the issue by adjusting the loop condition to ensure that all LBAs are cleared properly.

• Breaking change?
  • Breaking change - Does this PR cause a break in build or boot behavior?
  • Examples: Does it add a new library class or move a module to a different repo.
• Impacts security?
  • Security - Does this PR have a direct security impact?
  • Examples: Crypto algorithm change or buffer overflow fix.
• Includes tests?
  • Tests - Does this PR include any explicit test code?
  • Examples: Unit tests or integration tests.

How This Was Tested

Host based unit tests and code inspection

Integration Instructions

n/a

[spbrogan]

resolves #12396

[mikebeaton]

It is correct that LastBlock is (almost, see below) universally initialized to Size -1 (or copied from another last block value) in the codebase.

Could the comment be updated?
https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Protocol/BlockIo.h#L173-L177
e.g.

/// The last logical block address on the device (inclusive).

Additionally, Is this test wrong?

https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Bus/Pci/NvmExpressDxe/UnitTest/MediaSanitizeUnitTest.c#L589

[spbrogan]

It is correct that LastBlock is (almost, see below) universally initialized to Size -1 (or copied from another last block value) in the codebase.

Could the comment be updated? https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Protocol/BlockIo.h#L173-L177 e.g.

/// The last logical block address on the device (inclusive).

Additionally, Is this test wrong?

https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Bus/Pci/NvmExpressDxe/UnitTest/MediaSanitizeUnitTest.c#L589

This PR #12426 makes an update. I don't think it really mattered for the host-based unit test as the device was essentially mocked but I think it should be clear for intent.

[mikebeaton]

It is correct that LastBlock is (almost, see below) universally initialized to Size -1 (or copied from another last block value) in the codebase.
Could the comment be updated? https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Protocol/BlockIo.h#L173-L177 e.g.

/// The last logical block address on the device (inclusive).

Additionally, Is this test wrong?
https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Bus/Pci/NvmExpressDxe/UnitTest/MediaSanitizeUnitTest.c#L589

This PR #12426 makes an update. I don't think it really mattered for the host-based unit test as the device was essentially mocked but I think it should be clear for intent.

Thank you.

It is true that the UEFI spec. for EFI_BLOCK_IO_MEDIA is also unambiguous. The comment for LastBlock in the header file is not, however. Could/should it be updated, e.g. to:

  ///
  /// The last logical block address on the device (i.e. the
  /// total number of user addressable blocks minus one).
  /// If the media changes, then this field is updated.
  ///
  EFI_LBA    LastBlock;