feat: limit resource deletion on trigger#6754
Open
Jaakkonen wants to merge 1 commit intotilt-dev:masterfrom
Open
feat: limit resource deletion on trigger#6754Jaakkonen wants to merge 1 commit intotilt-dev:masterfrom
Jaakkonen wants to merge 1 commit intotilt-dev:masterfrom
Conversation
Currently if `tilt trigger` is run on a resource with RBACs, admission webhooks or ServiceAccounts those are removed causing cascading failures on other resources with `resource_deps` to them. This commit changes the `tilt trigger` logic to not call ForceDelete on this kind of resources while keeping for example `Job`s and `Pod`s in the scope of ForceDelete for faster development loops. Signed-off-by: Jaakko Sirén <jaakko@craci.com>
Jaakkonen
force-pushed
the
feat/trigger-safety
branch
from
d30cffb to
0eb018b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if
tilt triggeris run on a resource with RBACs, admission webhooks or ServiceAccounts those are removed causing cascading failures on other resources withresource_depsto them.This commit changes the
tilt triggerlogic to not call ForceDelete on this kind of resources while keeping for exampleJobs andPods in the scope of ForceDelete for faster development loops.