Repository navigation
Add --with-password to branch get and branch create - #281
Merged
Merged
Conversation
Like the service commands, branch get and branch create can include the branch's tsdbadmin password in their output and connection string. branch get fails when no password is stored, as service get does. branch create falls back to the password from the create response, which it keeps aside since waiting replaces the branch with one that carries none. A branch password update now points at branch get --with-password.
WaitForBranch replaced the whole branch on every poll, unlike WaitForService, which updates only the status. That dropped the create response's password, which the polls never return. Waiting now updates the status alone, as it does for services, so branch create reads the password straight off the branch.
prepareBranchForOutput skipped the connection details silently when a branch had no endpoint, where prepareServiceForOutput warns. Both now warn. The endpoint errors from GetConnectionDetails and pgpass storage said "service endpoint not available", though either can now be about a branch, so they say "endpoint not available".
nathanjcochran
force-pushed
the
nathan/branch-passwords
branch
from
October 28, 2026 20:26
94d5d51 to
95c416f
Compare
nathanjcochran
marked this pull request as ready for review
October 28, 2026 20:35
branch create accepted a --wait-timeout of zero or less, which made the wait time out immediately. It now refuses one, as service create does.
nathanjcochran
force-pushed
the
nathan/branch-passwords
branch
from
October 28, 2026 21:56
95c416f to
0af24fc
Compare
nathanjcochran
changed the title
--with-password to branch get and branch create
areina
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--with-passwordtotiger branch getandtiger branch create, which are behindTIGER_EXPERIMENTAL. It matches the flag onservice getandservice create.Passwordrow,passwordin JSON/YAML,PGPASSWORDwith-o env) and in the connection string. It's the branch's own password, never its parent's.branch get --with-passwordfails if no password is stored, likeservice get.branch create --with-passwordfalls back to the password from the create response, so it works even with--password-storage none.tiger branch get <branch> --with-passwordto view it, as it does for services.It also makes the branch and service flows behave the same in a few places:
endpoint not availablerather thanservice endpoint not available, since it can be about a branch, and so do the pgpass storage errors.branch createrefuses a--wait-timeoutthat isn't positive, asservice createdoes.The MCP side (
with_passwordonbranch_getandbranch_create) is in #271.