Repository navigation
build: tinybus by version range, patched to nested vendor (0.1.5) - #102
Conversation
…ybus (0.1.5) Co-authored-by: Medulla <medulla@tinyhumans.ai>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a87642912c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # used by the generated integration. Socket and CLI features are unnecessary | ||
| # here. | ||
| tinybus = { path = "vendor/tinybus/crates/tinybus", version = "0.1.2", default-features = false, features = [ | ||
| tinybus = { version = ">=0.1.3, <0.2", default-features = false, features = [ |
There was a problem hiding this comment.
Preserve direct paths to the vendored TinyBus crates
When tinycomputer is consumed from a parent workspace, Cargo ignores this dependency manifest's [patch.crates-io]; unless that parent duplicates all three patches, these version-only dependencies are resolved from crates.io, where the comment states TinyBus is unavailable, and the build fails before compilation. The previous direct paths made the pinned gitlink self-contained, and repository guidance explicitly requires retaining exact path dependencies unless a new module capability necessitates changing them. Keep the path entries while addressing host crate unification through a mechanism that does not make every parent workspace supply hidden patches.
AGENTS.md reference: AGENTS.md:L356-L361
Useful? React with 👍 / 👎.
Tiny Sweeper reviewThe change repoints the two TinyBus workspace dependencies from submodule path dependencies to crates-io version ranges (>=0.1.3, <0.2) backfilled by a [patch.crates-io] block over the same vendored submodule, matching the stated intent of building by version range with a patch to the nested vendor. No lane reported a defect in the diff itself. Multiple reviewers were unable to verify the vendored submodule contents or the lockfile state in this deployment, leaving whether the patched crates satisfy the version requirement and whether Cargo.lock still records the removed path entries unresolved. The tests lane reports no behavioural change, and the commits lane found nothing sensitive. Several lanes note the code index is behind this pull request (indexed at a083057), so retrieved context may be out of date. State: Ready for maintainer review Review snapshot
Completeness: Complete What changedCargo.toml is modified to replace the TinyBus dependency entries' submodule paths with crates-io version ranges (>=0.1.3, <0.2) retained with their default-features and feature list, and a new [patch.crates-io] section is added mapping tinybus, tinybus-macros, and tinybus-module back to nested vendor/tinybus submodule paths. The review evidence reports no other files changed and no behavioural change in tests. Features
TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Before mergeNone. Agent review detailscritique
security
tests
commits
description
Evidence and run details
|
There was a problem hiding this comment.
tinysweeper found nothing blocking. Approving.
$0.0003 · 116,384 in / 3,433 out · 20,096 cached (17%) · ladder/vectors-oai3, deepseek-v4.1-flash · 102 embedded
critique: $0.0001 · 46,746 in / 1,016 out · 7,168 cached (15%) · deepseek-v4.1-flash
security: $0.0001 · 47,217 in / 900 out · 6,912 cached (15%) · deepseek-v4.1-flash
description: $0.0001 · 20,288 in / 769 out · 6,016 cached (30%) · deepseek-v4.1-flash
Part of tinyhumansai/openhuman#7610, #7543, #7523
tinybus deps become
>=0.1.3, <0.2(no path dependency);[patch.crates-io]points at nested vendor/tinybus, bumped to 0.1.5. Build, 1446 tests and clippy 1.98 pass.Summary by CodeRabbit