Repository navigation
Conversation
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Add timezone, locale, accept_language, user_agent_metadata, screen, init_scripts and stealth to SessionOptions, all optional with serde defaults, and pass them to the engine's launch. A screen's pixel ratio also replaces the viewport's, which would otherwise overwrite it. Co-authored-by: Medulla <medulla@tinyhumans.ai>
feat(bus): identity fields in SessionOptions
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft until tinyhumansai/agent-browser#6 lands:
vendor/agent-browserpoints at a commit that is upstream only once that PR merges. Mark ready after it merges and the gitlink is confirmed on agent-browsermain.Summary
Adds browser identity fields to
SessionOptions(bus contract 2.20) and carries them through to agent-browser's launch identity and stealth options, with the agent-browser dependency bumped to match. Docs and the desktop module contract spec are updated, and the version constants and tests move with the contract.Rolled-up PRs:
Verification
cargo fmt --checkcleancargo clippy -p tinycomputer-bus -p tinycomputer-browser --all-targets -D warnings: passes except one unused import (CENTRE_JSinsurface/mod.rs) in a file this branch does not touchcargo test -p tinycomputer-bus -p tinycomputer-browser identity: all passCloses #109
Co-authored-by: Medulla medulla@tinyhumans.ai