Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/memory/sync/composio/providers/common.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,19 @@ use crate::memory::sync::traits::SkillDocument;

/// Walk a JSON document by dotted path and return the first non-empty scalar.
///
/// # Not interchangeable with [`normalize::helpers::pick_str`]
/// # Not interchangeable with `tinymemory_sync::helpers::pick_str`
///
/// A second `pick_str` lives in [`normalize::helpers`], and the two differ.
/// This one resolves paths with [`Value::pointer`] (so a numeric segment
/// indexes into an array) and **coerces `Number` to its string form**; that
/// one walks with [`Value::get`] (objects only) and returns `None` for any
/// A second `pick_str` lives in the `tinymemory-sync` crate, and the two
/// differ. This one resolves paths with [`Value::pointer`] (so a numeric
/// segment indexes into an array) and **coerces `Number` to its string form**;
/// that one walks with [`Value::get`] (objects only) and returns `None` for any
/// non-string leaf. Swapping one for the other changes what normalisers emit
/// for numeric fields. Keep them separate.
///
/// [`normalize::helpers`]: super::normalize::helpers
/// [`normalize::helpers::pick_str`]: super::normalize::helpers::pick_str
/// The other one used to sit beside this file, under
/// `providers::normalize::helpers`. It moved out of this crate entirely with
/// the host-side normalisers (tinymemory#18 §B3), which is why this note names
/// a crate rather than a sibling module.
pub fn pick_str(value: &Value, paths: &[&str]) -> Option<String> {
paths.iter().find_map(|path| {
let pointer = format!("/{}", path.replace('.', "/"));
Expand Down
1 change: 0 additions & 1 deletion src/memory/sync/composio/providers/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ mod google_docs;
mod google_drive;
mod google_sheets;
mod linear;
pub mod normalize;
mod notion;
mod outlook;
mod slack;
Expand Down
133 changes: 0 additions & 133 deletions src/memory/sync/composio/providers/normalize/clickup.rs

This file was deleted.

96 changes: 0 additions & 96 deletions src/memory/sync/composio/providers/normalize/clickup_tests.rs

This file was deleted.

130 changes: 0 additions & 130 deletions src/memory/sync/composio/providers/normalize/github.rs

This file was deleted.

Loading