Skip to content

fix(adaptive): lower run steps to the shell node's real config key - #63

Open
sanil-23 wants to merge 1 commit into
tinyhumansai:mainfrom
sanil-23:fix/recipe-shell-source-key
Open

fix(adaptive): lower run steps to the shell node's real config key#63
sanil-23 wants to merge 1 commit into
tinyhumansai:mainfrom
sanil-23:fix/recipe-shell-source-key

Conversation

@sanil-23

Copy link
Copy Markdown
Contributor

Field observation, three attempts of one episode: every run step failed with 'shell node missing inline script or script_path' while the author rationally iterated on the only thing its feedback named — a config key it does not write. The lowering emitted config.script; the engine's shell node reads config.source (or script_path). Machine-generated config the model cannot reach must not be wrong, and this one was — every previously satisfied recipe episode happened to be ask-only, which is how it hid.

One-word fix plus a drift-proof test: the test asks the engine's own shell contract which fields it requires and asserts the lowering fills one, so the lowering and the engine cannot silently drift apart again.

🤖 Generated with Claude Code

Field observation, three attempts of one episode: every run step failed
with 'shell node missing inline script or script_path' while the author
rationally iterated on the only thing the feedback named — a config key
it does not write. The lowering emitted `script`; the engine's shell
node reads `source` (or `script_path`). Machine-generated config the
model cannot reach must not be wrong, and this one was.

Every previously satisfied recipe episode happened to be ask-only, which
is how the defect hid. A new test asks the ENGINE's own shell contract
which fields it requires and asserts the lowering fills one, so the two
cannot drift apart silently again.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@sanil-23, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 43 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 003569e8-639d-42d2-83c6-aa3fd81a87b7

📥 Commits

Reviewing files that changed from the base of the PR and between 8f63a27 and e77c9da.

📒 Files selected for processing (2)
  • crates/adaptive/src/intake/recipe.rs
  • crates/adaptive/src/intake/recipe_tests.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

$0.0000 · 0 in / 0 out

@tinysweeper

tinysweeper Bot commented Aug 18, 2026

Copy link
Copy Markdown

How this change flows

1 changed behaviour across 9 relationships. 6 surrounding behaviours are shown (60 graph nodes walked). 29 further behaviours left out to keep the diagram readable.

flowchart LR
  n0["lower<br/>changed"]:::changed
  n1["map"]:::impacted
  n2["parse_steps"]:::impacted
  n3["push"]:::impacted
  n4["WorkflowGraph"]:::impacted
  n5["IntakeError"]:::impacted
  n6["Step"]:::impacted
  n0 -->|calls| n1
  n0 -->|calls| n2
  n0 -->|calls| n3
  n0 -->|uses| n4
  n0 -->|uses| n5
  n2 -->|calls| n1
  n2 -->|calls| n3
  n2 -->|uses| n5
  n2 -->|uses| n6
  classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
  classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
  classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
  classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Loading

Green: changed behaviour. Grey: surrounding behaviour. Arrows name the call, use, implementation, or test relationship. Orange: has findings. Red: has a finding that blocks the merge.

tinysweeper 0.1.0

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant