fix(adaptive): a mechanically broken run cannot be judged terminal

[sanil-23]

Field observation: a shell step exited nonzero, the judge answered missing_evidence, and the episode ended with two of its three attempts unused — when rewriting the script was the whole fix.

The taxonomy already says mechanical failures are goal_not_met (#59). Saying it is not enough: a model that misreads the instruction ends the episode, and no later round can undo that. This is the failure mode the crate normally answers with a mechanical gate rather than prompt hope, so:

• Evidence now carries the runner's own failure report (failed), separately from the outcome, because it decides something the model may not: whether another attempt is worth making.
• In judge, a non-continuable blocker over a failed run becomes GoalNotMet.
• NeedsInput / ExternalWait survive the downgrade — both mean something outside the loop must move, which a broken run does not change.
• A run that completed keeps whatever the judge decided, so this is not a blanket refusal to stand down.

Three regression tests pin all three arms.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

@sanil-23, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 5 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: be019635-62e4-4a53-9480-438bfcc2642e

📥 Commits

Reviewing files that changed from the base of the PR and between 8f63a27 and e94946a.

📒 Files selected for processing (3)

• crates/adaptive/src/closing/judge.rs
• crates/adaptive/src/closing/repair.rs
• crates/adaptive/src/execute/mod.rs

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[tinysweeper]

tinysweeper found nothing blocking. Approving.

$0.0000 · 0 in / 0 out · 332 embedded · openrouter/openai/text-embedding-3-small

[tinysweeper]

How this change flows

3 changed behaviours across 10 relationships. 4 surrounding behaviours are shown (60 graph nodes walked). 40 further behaviours left out to keep the diagram readable.

flowchart LR
  n0["judge<br/>changed"]:::changed
  n1["without_a_model<br/>changed"]:::changed
  n2["Ran<br/>changed"]:::changed
  n3["evidence"]:::impacted
  n4["verdict_for"]:::impacted
  n5["Evidence"]:::impacted
  n6["Diagnosis"]:::impacted
  n0 -->|calls| n1
  n0 -->|uses| n5
  n1 -->|uses| n5
  n2 -->|uses| n6
  n3 -->|uses| n5
  n3 -->|uses| n6
  n4 -->|calls| n0
  n4 -->|tests| n0
  n4 -->|uses| n5
  n5 -->|uses| n6
  classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
  classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
  classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
  classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff

Loading

_{Green: changed behaviour. Grey: surrounding behaviour. Arrows name the call, use, implementation, or test relationship. Orange: has findings. Red: has a finding that blocks the merge.}