fix(providers): validate Vercel::with_base_url's api root, not just connect_to's - #3
Conversation
…onnect_to's Co-authored-by: Medulla <medulla@tinyhumans.ai>
|
Warning Review limit reached
Next review available in: 37 minutes Limit details: You’ve used all 1 included review currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Vercel::with_base_urlbypassed thehttps://-or-loopback validation thatconnect_toapplies, so a caller reaching this public constructor directly with a non-loopbackhttp://root would send the bearer token in cleartext.with_base_urlnow runs the sameproviders::is_secure_base_urlcheck and returnsError::InsecureBaseUrlbefore building the client.Test plan
cargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningscargo build --all-targets --all-featurescargo test --all-features(new test:with_base_url_rejects_plain_http_against_a_non_loopback_host)cargo test(default features).github/scripts/check-file-coverage.sh 90 coverage.json(every file ≥90%)