Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket
PM-6515
What's in this PR?
Talent Managers can list non-internal projects in Work Manager but the UI rejects their project workspace and challenges unless they are project members. The shared
checkProjectAccesshelper now accepts bothTalent ManagerandTopcoder Talent Managerroles for projects successfully returned by the projects API.The API remains responsible for internal-project membership restrictions. Missing or rejected project data still denies access, and project/challenge mutation checks remain unchanged. Function documentation and the Work app README explain the access policy. Regression tests exercise normalized role names, workspace rendering, project challenge fetching, internal-project API rejection, and existing membership/mutation restrictions.
Reviewed
projects-api-v6on currentdev: its project-read service and project-context interceptor already implement the required non-internal access and internal active-membership restrictions, so no API change is needed.Validation
yarn lint: passedNODE_OPTIONS=--max-old-space-size=8192 yarn run build: passed (default Node heap was insufficient; source-map, CSS-order, and bundle-size warnings remain in unrelated dependencies/styles)Manual QA
/projects/:projectId/challengesdirectly; project details and challenges should load.