Skip to content

docs(links): record C4 hosted verification - #2214

Merged
josecelano merged 4 commits into
torrust:developfrom
josecelano:2185-record-c4-hosted-verification
Sep 14, 2026
Merged

josecelano merged 4 commits into
torrust:developfrom
josecelano:2185-record-c4-hosted-verification

Conversation

@josecelano

Copy link
Copy Markdown
Member

Records independently reviewed hosted verification for the C4 repository-controlled stale-link repair after PR #2212 merged.

Evidence

  • External Link Check run 34843399874 ran on merged develop revision 618723d49283432a99ea5604fc31becfa1a63a84.
  • The advisory check failed visibly with 28 unrelated errors; lychee-external-link-report uploaded successfully and is retained through 2026-09-28.
  • The report contains none of C4's three retired repository-controlled URLs and retains representative unrelated Caddy, third-party, FSF, Docker, GitHub-fragment, and Star History failures.
  • Issue-local independent review confirms the C4 evidence while C5-C8 and broader completion remain pending.

Related to #2185

Copilot AI lite review requested due to automatic review settings September 14, 2026 16:19
@josecelano josecelano self-assigned this Sep 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

One or more issues must be addressed before approval.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This documentation-only PR records hosted verification for the C4 stale-link repairs after PR #2212 merged.

Changes:

  • Updates issue progress and acceptance evidence with run 34843399874.
  • Records C4 report details and confirms unrelated failures remain visible.
  • Appends the independent hosted-verification review.
File summaries
File Description
docs/issues/open/2185-2003-triage-advisory-external-link-check-findings/ISSUE.md Updated as part of this pull request.
docs/issues/open/2185-2003-triage-advisory-external-link-check-findings/external-link-baseline.md Updated as part of this pull request.
docs/issues/open/2185-2003-triage-advisory-external-link-check-findings/agent-review-reports.md Updated as part of this pull request.
Review details

Suppressed comments (3)

docs/issues/open/2185-2003-triage-advisory-external-link-check-findings/ISSUE.md:144

  • Use the plural noun here: the sentence refers to the targets for both C3 and C4, not one combined target.
- [ ] AC2: Each repair changes only a verified stale reference and records why its replacement target is correct. C3 and C4 target and hosted verification are recorded; remaining repair slices must be verified before AC2 can be completed.

docs/issues/open/2185-2003-triage-advisory-external-link-check-findings/ISSUE.md:181

  • Use the plural noun here: the evidence row refers to the targets for both C3 and C4, not one combined target.
| AC2   | TODO                   | C3 and C4 target and hosted verification are recorded; remaining repair slices must be verified. |

docs/issues/open/2185-2003-triage-advisory-external-link-check-findings/agent-review-reports.md:114

  • This appended review entry still ends in REVIEW WARNED and says to add run 34843399874 to AC5, even though this same PR already adds that run at ISSUE.md:184. Because the report contract requires corrections to be recorded as a new entry rather than editing history, append a follow-up entry naming this warning and confirming the correction; otherwise the latest review record remains stale for the final diff.
  - Correction required: Add run 34843399874 to AC5's evidence row so the documented evidence explicitly includes the hosted rerun for the C4 remediation slice.
  - Pending: Keep T2 and AC2 pending for C5-C8 and remaining repair verification. Keep all issue-wide quality, manual-verification, acceptance-review, implementation-completion-review, and closure criteria pending.
- Verdict: REVIEW WARNED.
- Follow-up actions:
  - Make the AC5 evidence-row correction.
  • Files reviewed: 3/3 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

josecelano added a commit to josecelano/torrust-tracker that referenced this pull request Sep 14, 2026
@josecelano
josecelano force-pushed the 2185-record-c4-hosted-verification branch from 719b88d to b93fa5b Compare September 14, 2026 18:45
@josecelano

Copy link
Copy Markdown
Member Author

ACK b93fa5b

@josecelano
josecelano merged commit fb62f58 into torrust:develop Sep 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants