Repository navigation
Conversation
🦋 Changeset detectedLatest commit: fab88bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Size Change: -149 B (-0.12%) Total Size: 127 kB 📦 View Changed
ℹ️ View Unchanged
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v1-base #614 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 76 76
Lines 2447 2423 -24
Branches 790 785 -5
=========================================
- Hits 2447 2423 -24 🚀 New features to boost your workflow:
|
hyesungoh
marked this pull request as ready for review
November 19, 2026 06:21
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Closes #537
useDebouncedCallbackanduseThrottledCallbackcould not replace the deprecateduseDebounceanduseThrottle, because they forwarded a single value and hidcancel, which the shared implementation already returns.{ callback, debounceMs | throttleMs, leading, trailing }and return the wrapped function withcancel, typed fromcallback.onChangeis renamed tocallback. The hooks no longer skip a call that repeats the last forwarded value, so the old name no longer fits, and the rename makes existing calls fail to compile instead of changing behavior silently.useImpressionRef, the only place in the repo that relied on it, soonImpressionStartstill fires once when an element leaves and returns before the end is reported. Two regression tests cover this; the existing tests passed without the skip.callback.flushandisPendingare not part of this PR. The return value is a function with methods, so they can be added later in a minor release without breaking calls.Checklist
yarn run fixto format and lint the code and docs?yarn run test:coverageto make sure there is no uncovered line?