Repository navigation
TOW 966 add CLI regression tests and improve integration test - #108
Merged
Conversation
socksy
force-pushed
the
chore/tow-966-add-regression-tests-and-improve-integration-test
branch
from
September 27, 2025 00:11
cd1c027 to
8b13b53
Compare
socksy
changed the base branch from
develop
to
feature/tow-965-make-mcp-server-do-what-it-says-it-does
September 27, 2025 00:11
socksy
force-pushed
the
chore/tow-966-add-regression-tests-and-improve-integration-test
branch
2 times, most recently
from
September 27, 2025 04:17
422875d to
ba95ac2
Compare
socksy
changed the base branch from
feature/tow-965-make-mcp-server-do-what-it-says-it-does
to
feature/tow-967-fix-run-errors-responses
September 27, 2025 04:30
socksy
force-pushed
the
feature/tow-967-fix-run-errors-responses
branch
from
September 27, 2025 04:38
e5669f1 to
c89a1a4
Compare
- Fix the validation error tests' expectation of being deployed or not - check for "nonexistent_param" and return proper error model for undeployed and invalid params errors (cli is not matching http statuses!)
hmm this mock server is getting pretty featureful, when can it replace prod?
The mock server is stateful and with multiple tests running either after another (was getting issues with hello world being deployed when it shouldn't have been), and also with parallel workers, I think it's better we scope each test with their own unique hello_world app name. `test_app` remains non-unique - it needs to be expected to be there (I guess I could put it in the context, but it doesn't need to be yet so 🤷). Other alternative was resetting the mock DB but I figured that might lead to race conditions and it was better if this stuff was just as idempotent as possible
socksy
force-pushed
the
chore/tow-966-add-regression-tests-and-improve-integration-test
branch
from
September 27, 2025 04:45
ba95ac2 to
f606e63
Compare
- make sure we can access the app names across steps in a scenario - move to @step everywhere so we can use @when or @then without it complaining - make sure we deploy apps that are supposed to exist in advance - hardcode in the predeployed app, to really communicate that this app is a special case (maybe can be replaced with actual deploying later)
socksy
force-pushed
the
chore/tow-966-add-regression-tests-and-improve-integration-test
branch
from
September 29, 2025 15:06
17a8758 to
fa9ef7c
Compare
socksy
merged commit Sep 29, 2025
e3ff0c1
into
feature/tow-967-fix-run-errors-responses
5 checks passed
socksy
deleted the
chore/tow-966-add-regression-tests-and-improve-integration-test
branch
September 29, 2025 15:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests!