Skip to content

fix: build delete filters with PyIceberg expressions - #342

Closed
konstantinoscs wants to merge 1 commit into
feature/tow-2494-commit-retry-backofffrom
codex/tow-2494-iceberg-filter-expressions
Closed

konstantinoscs wants to merge 1 commit into
feature/tow-2494-commit-retry-backofffrom
codex/tow-2494-iceberg-filter-expressions

Conversation

@konstantinoscs

@konstantinoscs konstantinoscs commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Make SQL-like strings and native PyIceberg BooleanExpression objects the canonical delete filters.
  • Make Table.column() build structural PyIceberg predicates for all six comparisons, composition, and inversion.
  • Remove the unsafe rendered-PyArrow-string parser.
  • Raise PyArrowFilterMigrationError before write credential escalation for legacy PyArrow expressions/lists.
  • Document the migration mapping.

Migration

  • pc.field("age") >= 18 → table.column("age") >= 18
  • [a, b] → a & b
  • Compose with &, |, and ~, or pass a native PyIceberg expression/string directly.

Identifiers and literals containing and, or, or not are now handled structurally. S3 Tables/BYO catalog routing and credential behavior are unchanged.

Verification

  • Covers ==, !=, >, >=, <, <=, logical composition/inversion, nested and case-sensitive names, pathological text, unchanged forwarding, and pre-vend migration failures.
  • Full Stack A suite from the top: 225 passed, 10 skipped.

Stack

4 of 5 in Stack A. Base: #341. Next: #343.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9c10e9e4-b901-4872-9631-d6b4d7001419

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant